From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: 5923@debbugs.gnu.org
Subject: bug#5923: 23.1.95; minibuffer-message discards input events
Date: Sun, 18 Apr 2010 23:09:31 -0700 [thread overview]
Message-ID: <EE56D5192B7448138B8876177844DC3C@us.oracle.com> (raw)
In-Reply-To: <497D764814894831A571BD283D21B9DA@us.oracle.com>
> > > > Attached is the code I use for `C-u' in the minibuffer. I
> > > > hope it helps.
> > >
> > > It does.
> > >
> > > But to tell you the truth the handling of this-command-keys and
> > > universal-argument prefix is much too delicate for me to
> > > understand it, so I'm not surprised it doesn't work quite right
> > > if you mess with it in any non-trivial way.
> >
> > Compare Emacs 22 (and earlier), where there is no bug.
> >
> > The code was changed (C to Lisp, at least), and that
> > introduced the regression.
>
> Also, the code I use is _identical_ to the original code in
> simple.el (Emacs 22
> version), except that it also calls `minibuffer-message'. Is
> that really a
> "non-trivial" change?
>
> (And in Emacs 23, `last-command-event' is used instead of
> `last-command-char' - that is the only difference I can see
> from the Emacs 22 code.)
And changing `last-command-char' in the code to `last-command-event', for Emacs
23, does not fix the problem. It seems that the problem was introduced in the
translation from C to Lisp for the vanilla Emacs code for `minibuffer-message'.
Here is enough of the rest of the code I use to let you execute it and reproduce
the bug without doing anything extra:
(defun icicle-remap (old new map &optional oldmap)
(define-key map (vector 'remap old) new))
(icicle-remap 'universal-argument 'icicle-universal-argument ; `C-u'
minibuffer-local-completion-map (current-global-map))
(icicle-remap 'negative-argument 'icicle-negative-argument ; `M--'
minibuffer-local-completion-map (current-global-map))
(icicle-remap 'digit-argument 'icicle-digit-argument ; `C-9'
minibuffer-local-completion-map (current-global-map))
(defvar icicle-minibuffer-message-ok-p t)
Together with the code I sent before, this provides a full test case. It works
in Emacs 22 and doesn't work in Emacs 23.
next prev parent reply other threads:[~2010-04-19 6:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-10 16:52 bug#5923: 23.1.95; minibuffer-message discards input events Drew Adams
2010-04-10 19:15 ` Stefan Monnier
2010-04-10 19:59 ` Drew Adams
2010-04-14 2:19 ` Stefan Monnier
2010-04-14 5:06 ` Drew Adams
2010-04-19 5:38 ` Drew Adams
2010-04-19 6:09 ` Drew Adams [this message]
2010-04-20 16:18 ` Drew Adams
2010-04-20 23:45 ` Drew Adams
2010-04-21 0:05 ` Drew Adams
2010-07-23 22:26 ` Stefan Monnier
2010-07-28 15:24 ` Drew Adams
2016-07-05 4:06 ` npostavs
2016-07-05 14:19 ` Drew Adams
2016-07-06 13:11 ` Noam Postavsky
2016-07-06 13:59 ` Drew Adams
2016-07-06 14:55 ` Noam Postavsky
2016-07-06 15:05 ` Eli Zaretskii
2016-07-06 15:30 ` Noam Postavsky
2016-07-06 15:38 ` Eli Zaretskii
2016-07-06 14:25 ` bug#3938: " Eli Zaretskii
2016-07-06 15:10 ` bug#5923: " Drew Adams
2016-07-06 15:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EE56D5192B7448138B8876177844DC3C@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=5923@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.