bug#1151: #1151 - Building Emacs on Mac OS 10.3.9 - Emacs bug report logs

bug#1151: #1151 - Building Emacs on Mac OS 10.3.9 - Emacs bug report logs

[Adrian Robert]

Hi,

I am interested in having Emacs continue to work under Panther but  
don't have access to a test environment myself.  Could you try  
commenting out the part of the 'if' statement involving  
"typeUTF16ExternalRepresentation" and see where that gets you?

If you get it working and send me a list of all places that you needed  
to change, I can put in #ifdefs etc. so it will work out of the box.

thanks,
Adrian

bug#1151: #1151 - Building Emacs on Mac OS 10.3.9 - Emacs bug report logs

[Alex Schröder]

On Tue, Oct 21, 2008 at 2:42 PM, Adrian Robert
<adrian.b.robert@gmail.com> wrote:
> I am interested in having Emacs continue to work under Panther but don't
> have access to a test environment myself.  Could you try commenting out the
> part of the 'if' statement involving "typeUTF16ExternalRepresentation" and
> see where that gets you?
>
> If you get it working and send me a list of all places that you needed to
> change, I can put in #ifdefs etc. so it will work out of the box.

Hi Adrian

Indeed, that does work!

This is the only change I made:

cvs diff: Diffing src
Index: src/nsfns.m
===================================================================
RCS file: /sources/emacs/emacs/src/nsfns.m,v
retrieving revision 1.29
diff -c -r1.29 nsfns.m
*** src/nsfns.m	7 Dec 2008 05:00:56 -0000	1.29
--- src/nsfns.m	23 Dec 2008 01:27:36 -0000
***************
*** 2054,2061 ****
  	  *result = Qt;
  	  // script returned an AppleScript result
  	  if ((typeUnicodeText == [returnDescriptor descriptorType]) ||
! 	      (typeUTF16ExternalRepresentation
! 	       == [returnDescriptor descriptorType]) ||
  	      (typeUTF8Text == [returnDescriptor descriptorType]) ||
  	      (typeCString == [returnDescriptor descriptorType]))
  	    {
--- 2054,2061 ----
  	  *result = Qt;
  	  // script returned an AppleScript result
  	  if ((typeUnicodeText == [returnDescriptor descriptorType]) ||
! // 	      (typeUTF16ExternalRepresentation
! // 	       == [returnDescriptor descriptorType]) ||
  	      (typeUTF8Text == [returnDescriptor descriptorType]) ||
  	      (typeCString == [returnDescriptor descriptorType]))
  	    {

bug#1151: #1151 - Building Emacs on Mac OS 10.3.9 - Emacs bug report logs

[Adrian Robert]

On Dec 23, 2008, at 3:31 AM, Alex Schröder wrote:

> On Tue, Oct 21, 2008 at 2:42 PM, Adrian Robert
> <adrian.b.robert@gmail.com> wrote:
>> I am interested in having Emacs continue to work under Panther but  
>> don't
>> have access to a test environment myself.  Could you try  
>> commenting out the
>> part of the 'if' statement involving  
>> "typeUTF16ExternalRepresentation" and
>> see where that gets you?
>>
>> If you get it working and send me a list of all places that you  
>> needed to
>> change, I can put in #ifdefs etc. so it will work out of the box.
>
> Hi Adrian
>
> Indeed, that does work!

Great to hear, I will apply a version of this patch using appropriate  
#ifdefs soon after the holidays, or feel free to commit one yourself  
if you have access.

thanks,
Adrian



> This is the only change I made:
>
> cvs diff: Diffing src
> Index: src/nsfns.m
> ===================================================================
> RCS file: /sources/emacs/emacs/src/nsfns.m,v
> retrieving revision 1.29
> diff -c -r1.29 nsfns.m
> *** src/nsfns.m	7 Dec 2008 05:00:56 -0000	1.29
> --- src/nsfns.m	23 Dec 2008 01:27:36 -0000
> ***************
> *** 2054,2061 ****
>   	  *result = Qt;
>   	  // script returned an AppleScript result
>   	  if ((typeUnicodeText == [returnDescriptor descriptorType]) ||
> ! 	      (typeUTF16ExternalRepresentation
> ! 	       == [returnDescriptor descriptorType]) ||
>   	      (typeUTF8Text == [returnDescriptor descriptorType]) ||
>   	      (typeCString == [returnDescriptor descriptorType]))
>   	    {
> --- 2054,2061 ----
>   	  *result = Qt;
>   	  // script returned an AppleScript result
>   	  if ((typeUnicodeText == [returnDescriptor descriptorType]) ||
> ! // 	      (typeUTF16ExternalRepresentation
> ! // 	       == [returnDescriptor descriptorType]) ||
>   	      (typeUTF8Text == [returnDescriptor descriptorType]) ||
>   	      (typeCString == [returnDescriptor descriptorType]))
>   	    {

bug#1151: #1151 - Building Emacs on Mac OS 10.3.9 - Emacs bug report logs

[Alex Schröder]

I've come back to my Mac after a few days and noticed a problem with
the patched version. My Mac has a Swiss German keyboard. The keys
producing ASCII characters all work. Therefore the layout is correct.
But the non-ASCII are wrong: The sequence çäöüàéè results in Á‰ˆ¸‡ÈË,
for example.

I'm not sure this is related to the patch, because the patch concerns
ns_do_applescript… Hm...

> On Tue, Oct 21, 2008 at 2:42 PM, Adrian Robert wrote:
>> commenting out the
>> part of the 'if' statement involving "typeUTF16ExternalRepresentation" and
>> see where that gets you?

bug#1151: #1151 - Building Emacs on Mac OS 10.3.9 - Emacs bug report logs

[Alex Schröder]

More info on the strange mapping for äöü and related non-ASCII
characters. When I use C-h k ä I get the following information:

‰ (translated from ä) runs the command self-insert-command, which is
an interactive built-in function in `C source code'.

So Emacs does at some point in time recognize the ä.

On Mon, Dec 29, 2008 at 12:05 PM, Alex Schröder <kensanata@gmail.com> wrote:
> I've come back to my Mac after a few days and noticed a problem with
> the patched version. My Mac has a Swiss German keyboard. The keys
> producing ASCII characters all work. Therefore the layout is correct.
> But the non-ASCII are wrong: The sequence çäöüàéè results in Á‰ˆ¸‡ÈË,
> for example.
>
> I'm not sure this is related to the patch, because the patch concerns
> ns_do_applescript… Hm...

bug#1151: #1151 - Building Emacs on Mac OS 10.3.9 - Emacs bug report logs

[Alex Schröder]

I was able to reproduce this bug on my unpatched Emacs running on Mac
OS 10.4 so I will open a new bug.

On Mon, Dec 29, 2008 at 1:56 PM, Alex Schröder <kensanata@gmail.com> wrote:
> More info on the strange mapping for äöü and related non-ASCII
> characters. When I use C-h k ä I get the following information:
>
> ‰ (translated from ä) runs the command self-insert-command, which is
> an interactive built-in function in `C source code'.
>
> So Emacs does at some point in time recognize the ä.