From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Serghei Iakovlev Newsgroups: gmane.emacs.devel Subject: Re: esup byte compile warnings Date: Wed, 29 Jan 2020 14:42:04 +0000 Message-ID: References: <15aa1d01-dcff-34c0-0232-141edf1b3739@protonmail.ch> <104542A5-436D-44DB-AEE2-9DB5D64FAC01@protonmail.ch> Reply-To: Serghei Iakovlev Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="44086"; mail-complaints-to="usenet@ciao.gmane.io" Cc: GNU Emacs Developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 29 15:42:44 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iwoYF-000BRL-Ry for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Jan 2020 15:42:43 +0100 Original-Received: from localhost ([::1]:47564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwoYE-0002eQ-Sl for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Jan 2020 09:42:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56870) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwoXl-0002Cd-Mj for emacs-devel@gnu.org; Wed, 29 Jan 2020 09:42:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwoXk-0005U7-FC for emacs-devel@gnu.org; Wed, 29 Jan 2020 09:42:13 -0500 Original-Received: from mail1.protonmail.ch ([185.70.40.18]:31535) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iwoXj-0005Tg-UR for emacs-devel@gnu.org; Wed, 29 Jan 2020 09:42:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.ch; s=default; t=1580308930; bh=1tGKCsXykTTa97pYptZBAoOu10oHlPSZ3jDu25rjpW4=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References: Feedback-ID:From; b=Gd0aozebuBF3AHAk3zJ5sAxkmS18WMoThIfVdHyf2qJyJB5TGs5LseSZxS2X8Kefk BTBjOhiF7YG4qPu+NO1x5kvVCL2khRY2AlckywydedZDV/wUH8bdrPRkyWFQGpHXG4 nd532+8I/+GWvdESw/rHLvPrLCtZoF++8oL6tTGc= In-Reply-To: Feedback-ID: _R8KJzte5sz8SQWHcnDN91Kshyr4gZBHh1d2Efk8ItHfFJEyfsSrvYKxlFgM-K6SqCAHswKFjJZAghkXSedbVg==:Ext:ProtonMail X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.70.40.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244750 Archived-At: > Oh, I think it's because of >=20 > (let ((load-path (append load-path (list esup-load-path)))) > (require 'esup-child)) >=20 Good catch! Thank you. Actually I planned to remove this earlier but didn't noticed this relation. > PS: While I'm here I noticed: >=20 > (eval-when-compile > (if (and (<=3D emacs-major-version 24) > (<=3D emacs-minor-version 3)) > (require 'cl) > (require 'cl-lib))) >=20 > which makes no sense: those two libraries provide the same *kind* of > functionality, but under completely different names. The rest of the > code uses things like `cl-loop`, so you need to (require 'cl-lib) > because that's what the code uses. In Emacs<24.4, `cl-lib` will itself > load `cl` (because it uses it internally, but that's an implementation > detail). >=20 Yes, this is fixed in the separated branch (=E2=80=98byte-war=E2=80=99) whi= ch I have not yet merged into master.