From: Serghei Iakovlev <egrep@protonmail.ch>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: GNU Emacs Developers <emacs-devel@gnu.org>
Subject: Re: esup byte compile warnings
Date: Wed, 29 Jan 2020 14:42:04 +0000 [thread overview]
Message-ID: <ED03EE98-9A59-4185-B193-7B449C9DDB2A@protonmail.ch> (raw)
In-Reply-To: <jwveevigxbd.fsf-monnier+emacs@gnu.org>
> Oh, I think it's because of
>
> (let ((load-path (append load-path (list esup-load-path))))
> (require 'esup-child))
>
Good catch! Thank you. Actually I planned to remove this earlier
but didn't noticed this relation.
> PS: While I'm here I noticed:
>
> (eval-when-compile
> (if (and (<= emacs-major-version 24)
> (<= emacs-minor-version 3))
> (require 'cl)
> (require 'cl-lib)))
>
> which makes no sense: those two libraries provide the same *kind* of
> functionality, but under completely different names. The rest of the
> code uses things like `cl-loop`, so you need to (require 'cl-lib)
> because that's what the code uses. In Emacs<24.4, `cl-lib` will itself
> load `cl` (because it uses it internally, but that's an implementation
> detail).
>
Yes, this is fixed in the separated branch (‘byte-war’) which I have
not yet merged into master.
prev parent reply other threads:[~2020-01-29 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 20:48 esup byte compile warnings Serghei Iakovlev
2020-01-24 21:55 ` Stefan Monnier
2020-01-29 12:56 ` Serghei Iakovlev
2020-01-29 14:32 ` Stefan Monnier
2020-01-29 14:42 ` Serghei Iakovlev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED03EE98-9A59-4185-B193-7B449C9DDB2A@protonmail.ch \
--to=egrep@protonmail.ch \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.