From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#64799: [PATCH] Add 'project-prompt-key' face Date: Wed, 23 Aug 2023 12:18:02 +0000 Message-ID: References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <87ttsq2gil.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18127"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Protesilaos Stavrou , 64799@debbugs.gnu.org To: Visuwesh , Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 23 14:19:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qYmpP-0004UR-Ai for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Aug 2023 14:19:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYmpA-0007mN-Nw; Wed, 23 Aug 2023 08:19:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYmp8-0007mE-MN for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 08:18:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYmp8-0008LF-E2 for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 08:18:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qYmpB-0001d8-Ov for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 08:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Aug 2023 12:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64799-submit@debbugs.gnu.org id=B64799.16927930996198 (code B ref 64799); Wed, 23 Aug 2023 12:19:01 +0000 Original-Received: (at 64799) by debbugs.gnu.org; 23 Aug 2023 12:18:19 +0000 Original-Received: from localhost ([127.0.0.1]:33099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYmoV-0001bu-FD for submit@debbugs.gnu.org; Wed, 23 Aug 2023 08:18:19 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:50165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYmoR-0001bd-Ro for 64799@debbugs.gnu.org; Wed, 23 Aug 2023 08:18:18 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1F15A240104 for <64799@debbugs.gnu.org>; Wed, 23 Aug 2023 14:18:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692793086; bh=KYFvFc+tHUcZdFxwXqvrgJa6XCN73Wrf+1soEmdVt0o=; h=Date:From:To:CC:Subject:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=Mhrr/LNXnJVH5oF0IkjCz/sLXgdoSv5wm/+zpZHErgOMPHVwo9KYm6eK3IG/Dbiy9 uAQorJP+gAHYcr8Vd2Vnv0HtMQT/zRqwiKGibmuyHDDfpEIJHidD6plW6PLgcEtvqA s9Gf6uBHXZnu9pUZsaykOdVHzhXTFIjg0AReVkp3IK+iGYTzrO9t6Hrsrn6lAr2BmY OiZQr8hVOXY2qSlhUT0AQoq/8h0w/gbgT4VLKLNaY705DDl6G7FqR69cPNHrTdzUtH JXjkt1rWYIWGiR8X6fvXRWoiC0450YOnZvA/+pymIqxrBLYYBK3/sEkkxTjQQk4tbb HiV8Edsl2jKTA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RW4x91M3jz9rxH; Wed, 23 Aug 2023 14:18:05 +0200 (CEST) In-Reply-To: <87ttsq2gil.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268235 Archived-At: Would remapping help-key-binding to bold be a possible solution? On August 23, 2023 12:35:14 PM GMT+02:00, Visuwesh = wrote: >[=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE= =9C=E0=AF=82=E0=AE=B2=E0=AF=88 27, 2023] Dmitry Gutov wrote: > >> On 26/07/2023 07:50, Protesilaos Stavrou wrote: >>> For my use, and Emacs 28+, I want this: >>> (format "%s %s" >>> (propertize (key-description key) 'face 'project-promp= t-key) >>> label) >>> The reason I mentioned the possibility of a user option is because >>> without the square brackets the bold face will not have the same effec= t >>> as the current design=2E The square brackets help add structure and m= ake >>> it easier to identify the keys=2E The use of 'bold' without the squar= e >>> brackets may make it more difficult for users to spot the keys=2E >> >> The change in format seems to go hand-in-hand with the change in face, >> though, because help-key-binding has a box already=2E >> >> Does this look good to everybody? > >Sorry for replying so late=2E I make help-key-binding look the same as >the default face, and now I can't distinguish the keys from the labels >anymore since the former aren't bold anymore=2E :-( >Can there a way to get them back? If you think it would be too ugly, >then I can locally patch the function=2E > >[ FWIW, I liked the bold approach since it is similar to what > read-multiple-choice does=2E ]