From: Eli Zaretskii <eliz@gnu.org>
To: emacs-devel@gnu.org,
Stephen Leake <stephen_leake@stephe-leake.org>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: [PATCH 2/3] Don't print "process finished" into the stderr buffer.
Date: Tue, 10 Apr 2018 07:59:05 +0300 [thread overview]
Message-ID: <EC3BC449-4312-4749-8CA7-16B1585366F8@gnu.org> (raw)
In-Reply-To: <86efjn3dg0.fsf@stephe-leake.org>
On April 10, 2018 7:14:39 AM GMT+03:00, Stephen Leake <stephen_leake@stephe-leake.org> wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Philipp Stephani <p.stephani2@gmail.com>
> >> Date: Sat, 07 Apr 2018 20:21:40 +0000
> >> Cc: emacs-devel@gnu.org, phst@google.com
> >>
> >> > * src/process.c (syms_of_process): Add 'ignore' symbol.
> >> > (Fmake_process): Use it as sentinel for the standard error pipe
> >> > process.
> >>
> >> Why would we want that, and by default on top of that? Please
> give at
> >> least some rationale behind this change.
> >>
> >> Neither the manual not the docstring for `make-process' specify
> that
> >> Emacs prints "Process foo stderr
> >> finished" at the end of the standard error buffer, so that message
> >> shouldn't be printed.
> >
> > That assumes that the documentation is correct and the code isn't;
> it
> > could be the other way around.
> >
> > But I'm guessing that the current behavior was unexpected for some
> > reason, and that's why you looked in the documentation. If the
> guess
> > is correct, could you describe why it was unexpected/unwanted?
>
> I had to work around that behavior as well, in DVC (Emacs front end
> for
> some CM tools). When you are parsing the output of a process, that
> string is unexpected.
Are we talking about the same thing? Inserting the exit status into the process
buffer by the default sentinel is veteran Emacs behavior; if you don't want that,
you are supposed to define your own sentinel.
Philipp suggested to avoid this *only* for buffers collecting stderr output,
and *only* when make-process defines :stderr. That's a much more specialized
situation, which is also quite new. By contrast, what you are saying seems to
suggest changes in general behavior of make-process that IMO are a no-starter
at this time.
next prev parent reply other threads:[~2018-04-10 4:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 12:02 [PATCH 1/3] Document that 'make-process' mixes the output streams Philipp Stephani
2018-04-04 12:02 ` [PATCH 2/3] Don't print "process finished" into the stderr buffer Philipp Stephani
2018-04-04 13:14 ` Eli Zaretskii
2018-04-07 20:21 ` Philipp Stephani
2018-04-08 13:13 ` Eli Zaretskii
2018-04-10 4:14 ` Stephen Leake
2018-04-10 4:59 ` Eli Zaretskii [this message]
2019-04-19 19:28 ` Philipp Stephani
2019-04-20 7:30 ` Eli Zaretskii
2019-04-21 13:55 ` Philipp Stephani
2019-04-21 19:09 ` Eli Zaretskii
2019-04-21 20:57 ` Stefan Monnier
2019-04-22 9:37 ` Eli Zaretskii
2019-04-22 14:43 ` Stefan Monnier
2019-04-22 15:23 ` Eli Zaretskii
2019-04-22 15:45 ` Philipp Stephani
2019-04-22 15:52 ` Eli Zaretskii
2018-04-04 12:02 ` [PATCH 3/3] Inherit process output coding system to stderr process Philipp Stephani
2018-04-04 13:39 ` Eli Zaretskii
2018-04-07 21:12 ` Philipp Stephani
2018-04-08 13:18 ` Eli Zaretskii
2018-04-08 16:39 ` Eli Zaretskii
2018-04-04 13:12 ` [PATCH 1/3] Document that 'make-process' mixes the output streams Eli Zaretskii
2018-04-07 20:18 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EC3BC449-4312-4749-8CA7-16B1585366F8@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.