From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#61093: Indented file names confuse compilation buffer Date: Fri, 27 Jan 2023 15:34:44 +0100 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38644"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Sascha Ziemann To: 61093@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 27 15:35:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLPp0-0009tn-G1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Jan 2023 15:35:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLPom-0006JU-9V; Fri, 27 Jan 2023 09:35:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLPok-0006JA-2t for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 09:35:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLPoj-0006Vm-Rg for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 09:35:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLPoj-0004wz-Ii for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 09:35:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Jan 2023 14:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61093 X-GNU-PR-Package: emacs Original-Received: via spool by 61093-submit@debbugs.gnu.org id=B61093.167483009519012 (code B ref 61093); Fri, 27 Jan 2023 14:35:01 +0000 Original-Received: (at 61093) by debbugs.gnu.org; 27 Jan 2023 14:34:55 +0000 Original-Received: from localhost ([127.0.0.1]:36970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLPod-0004wX-76 for submit@debbugs.gnu.org; Fri, 27 Jan 2023 09:34:55 -0500 Original-Received: from mail-ej1-f48.google.com ([209.85.218.48]:35479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLPoa-0004wA-0b for 61093@debbugs.gnu.org; Fri, 27 Jan 2023 09:34:53 -0500 Original-Received: by mail-ej1-f48.google.com with SMTP id rl14so14289441ejb.2 for <61093@debbugs.gnu.org>; Fri, 27 Jan 2023 06:34:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=G1pvEPMmPLi5WYOPM0buSvcsAEPIbkOhSka4/cC7qQs=; b=EDsc1UKJAEkeRPBhDhSkja8IfBzYu5UAmnvzG7aFXKyNjDxDOCnotAApwTDCpY51c4 UKLMdVH0HqS8F6iajOqoMneuQ01j535A/CD/QO4ISqe9NMCXZsQgOPq6yHG5aj9P6OB8 1jLcdK1ftEgye2Bbwi8bPBbd8pBE3GyYPCjxwXRsLklIOJJ1yRYlogigPSl4Y6rwJueB gM5bazJ029nan3Bm/sLn4fUmtX0uKtf1THh1AHKljTlMZSXLlbwDrJwf7mIW834rqavk lmh/EiJwrS2QxQuL3MExO4Nmlvvhv9uNY9ECZeTPq4Y2GdwtFzKf8JCI/+iaVOmkevQb KbvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G1pvEPMmPLi5WYOPM0buSvcsAEPIbkOhSka4/cC7qQs=; b=ytArx5Fpmcezr9zBH57P/E/UOpt3UB8l21aoph+BA6+7Op+XYHyGjIFzndB8cqs30q Ckg5UURf46a8AbWZ13W70mdvIEa845rDcVLDGN5yY54jA5+GCiUe3OnLVFFa1NK6g2MY smxs4MRjrhW8FJ60uy44st3Gd02pZrc57Er/nK+MEshZTC0WaogQUlx3GN22NZMUHgUX 0U7RVeFml4FZbN1Ur+G98AJd4zY03G5m6djuKb4RcUS8U43pVdy/KiytIw/OBTn17UTx BddmLPGyX2PDF+pDmBaRgGzr430+TIsB49hJItDEm44F34XAwtgjShXrJESunSyqxxN+ gCkg== X-Gm-Message-State: AO0yUKVdkamjA2waKppr70vNH8aNHP6SBM3j0H3uL4MNZRupkX5mSVNM 0In+lclXYa0HiqxOe59CXqz/uM+Etos= X-Google-Smtp-Source: AK7set9rRrj26UZi+Ly5AHarJHU0B1o2qZ6/fYX1a/l2bEV7zJ1qEol8V8KNR+4DsLn+RRxfh2XMBA== X-Received: by 2002:a17:906:230b:b0:87b:d2a2:e7a6 with SMTP id l11-20020a170906230b00b0087bd2a2e7a6mr2718179eja.65.1674830085992; Fri, 27 Jan 2023 06:34:45 -0800 (PST) Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id r5-20020a170906a20500b00871075bfcfesm2317242ejy.133.2023.01.27.06.34.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Jan 2023 06:34:45 -0800 (PST) X-Mailer: Apple Mail (2.3654.120.0.1.13) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254260 Archived-At: > I think it might be ok to ignore leading whitespace, because file > names do not start very often with whitespace. The story goes like this: a tool uses a modification of the GNU message = format and its users then expect Emacs to conform to that variant. The problem with doing that is that each little tweak makes the = compilation message rules less robust and more likely to collide with = one another and become slower. There are about 60 regexps now, most of = which are used by very few people, and we keep adding. Build logs can = become quite long so performance is not unimportant. Maybe it's safe to accept and ignore not arbitrary leading whitespace = but a single tab, which your tool seems to emit. Or you could ask those = making it to cease emitting the tab. You could also put your own rule in compilation-regexp-alist. It might = look like this: ;; Message pattern for ancillary locations (notes) from the Go compiler (let ((rule `(go-note ,(rx bol "\t" (group ; 1: hyperlink (group ; 2: file (not (in " \t\n:")) (* (not (in "\t\n")))) ":" (group (+ digit)) ; 3: line ":" (group (+ digit)) ; 4: column ":") " " (+ nonl)) ; message 2 3 4 0 1))) (setq compilation-error-regexp-alist-alist (remq (assq 'go-note compilation-error-regexp-alist-alist) compilation-error-regexp-alist-alist)) (push rule compilation-error-regexp-alist-alist) (setq compilation-error-regexp-alist (remq 'go-note compilation-error-regexp-alist)) (push 'go-note compilation-error-regexp-alist))