From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Carsten Dominik Newsgroups: gmane.emacs.devel Subject: Re: recent changes to org files Date: Tue, 23 Oct 2007 22:09:12 +0200 Message-ID: References: <8D11CC21-71C6-4BCE-ACBC-090E429E311A@science.uva.nl> <86k5pe6t4e.fsf@lola.quinscape.zz> <1100BA17-7426-4C73-9EF0-FF90C1859B47@gmail.com> <86bqaq6pza.fsf@lola.quinscape.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1193170184 20461 80.91.229.12 (23 Oct 2007 20:09:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Oct 2007 20:09:44 +0000 (UTC) Cc: John Wiegley , Glenn Morris , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 23 22:09:44 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IkQ4J-0004UM-UL for ged-emacs-devel@m.gmane.org; Tue, 23 Oct 2007 22:09:40 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IkQ4B-00060P-LT for ged-emacs-devel@m.gmane.org; Tue, 23 Oct 2007 16:09:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IkQ46-0005xb-Ux for emacs-devel@gnu.org; Tue, 23 Oct 2007 16:09:27 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IkQ43-0005wn-Gi for emacs-devel@gnu.org; Tue, 23 Oct 2007 16:09:26 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IkQ43-0005wk-Dy for emacs-devel@gnu.org; Tue, 23 Oct 2007 16:09:23 -0400 Original-Received: from nf-out-0910.google.com ([64.233.182.189]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IkQ43-0002JL-1d for emacs-devel@gnu.org; Tue, 23 Oct 2007 16:09:23 -0400 Original-Received: by nf-out-0910.google.com with SMTP id f5so1302635nfh for ; Tue, 23 Oct 2007 13:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer; bh=dbaZWpMBZVcH9rm1OFbHxeG53ppUCEX8Yp4CXfZFD5Y=; b=YV+hZDUKZ29dqd+wPkI5Kjsk4CXjnoCezcg+CPTuUT1Y81Mnhh+kihX7rb5F7kNcBojqzIx5jjQdg1g/UHPgwksu8+Un5Qlv3k4qybjHshvcPZQGj0cfKlN2z/uYBMd2j9ODeLeZUbFQKByU+cNlB0ynZEQcPWpUVW/I3LdIjAc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer; b=U8PuWG45YMpQ4Uwaw3+MTDdMKOiI6hsgxc85U+B77UfvzXSA9ASYSKO1MEeUDDTTtvijOiE9rMOJgdZf1ioQE/MHaqt1VVDX/nAXqgwswhriq013KNmPNAi6V/hSWUmwgbS1MRPFtR8s7JMZrLdZYmTuyHjXWU/Ih2wZdG29PZc= Original-Received: by 10.86.84.5 with SMTP id h5mr5014367fgb.1193170162035; Tue, 23 Oct 2007 13:09:22 -0700 (PDT) Original-Received: from ?192.168.2.2? ( [81.71.213.43]) by mx.google.com with ESMTPS id b33sm9057379ika.2007.10.23.13.09.18 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 23 Oct 2007 13:09:19 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.752.2) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81592 Archived-At: On Oct 23, 2007, at 4:43 PM, Stefan Monnier wrote: >> affect many files, and it is impossible for the developer who does >> the >> change to be sure in all cases that he has done the right thing. > > In the case of "next-line -> forward-line" it is quite possible to > be sure: > just think hard about what the function should do in the presence of > invisible text or images, check at which the column the function may > terminate, check if it may be desired to add newlines at EOB, ... > > In the case of org-mode the presence of `invisible' in the code is > a good > indication that there's a good chance that the change is unsafe. > >> that has happened sometimes: I get an email with proposed >> changes, with >> the request to check them before they are committed. For example, >> Stefan >> has been doing things like this, and I appreciate his comments and >> additions, and the way he handles it, a lot. > > Actually I often can't be bothered to wait, so I install the change > and then > send an email about it Also that helps, thanks. - Carsten > (I sometimes prefer to undo/refine the change later, > also because installing the `undo' is a good opportunity to add a > comment in > the code explaining why it's the way it is). > > > Stefan