From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Adrian Robert Newsgroups: gmane.emacs.devel Subject: Changes 2009-07-15/16 in branch? Date: Thu, 23 Jul 2009 07:22:55 -0400 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v935.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1248348218 8533 80.91.229.12 (23 Jul 2009 11:23:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 23 Jul 2009 11:23:38 +0000 (UTC) Cc: Emacs-Devel devel To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 23 13:23:31 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MTwOY-0005rI-JT for ged-emacs-devel@m.gmane.org; Thu, 23 Jul 2009 13:23:30 +0200 Original-Received: from localhost ([127.0.0.1]:40881 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTwOX-0002Gy-SH for ged-emacs-devel@m.gmane.org; Thu, 23 Jul 2009 07:23:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTwOM-0002Gt-4y for emacs-devel@gnu.org; Thu, 23 Jul 2009 07:23:18 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTwOF-0002Dn-Md for emacs-devel@gnu.org; Thu, 23 Jul 2009 07:23:16 -0400 Original-Received: from [199.232.76.173] (port=46337 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTwOE-0002DZ-Pd for emacs-devel@gnu.org; Thu, 23 Jul 2009 07:23:11 -0400 Original-Received: from mail-qy0-f183.google.com ([209.85.221.183]:38624) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTwOE-0005oH-BI for emacs-devel@gnu.org; Thu, 23 Jul 2009 07:23:10 -0400 Original-Received: by qyk13 with SMTP id 13so1101704qyk.14 for ; Thu, 23 Jul 2009 04:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :content-type:content-transfer-encoding:mime-version:subject:date:cc :x-mailer; bh=8ovOENZ02EDTG/hEx8EvNUhDNXlVF5blXm65IUsyerY=; b=ALyjKPrh5dDFFUNabwCY5nU89dINoDqtxGvSK0hIGye1Y30HryDQEfvpvJvrBf3Jna qNPRh+wWwdYIXJYZEIOqzHAGAKRL4FW2LYcU+o3z6dKaSxPHvF+3oq/2dVqVcxYhEgxM WBrarnSI+S6LTsfXwR6V+DeWEpqbqJURme2fU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:content-type:content-transfer-encoding :mime-version:subject:date:cc:x-mailer; b=W+UeP1Kx+L1gYvucRIGoFioG2yIn/rWUBGOlTpuTyy8zGPhk6B/8b7B3EvuYV+zGjY jIAdmSvb4YW5/lkGopriLzIzH6U23yKamJ79tKyDm+4tZyTvpM4mEZreAk6ys6c7ULcZ fZ8vDGEwDM3mRegWPBSmB9QdBBzhO0wcrTIog= Original-Received: by 10.224.60.206 with SMTP id q14mr1857971qah.334.1248348189513; Thu, 23 Jul 2009 04:23:09 -0700 (PDT) Original-Received: from ?10.0.1.3? (dpc6745214221.direcpc.com [67.45.214.221]) by mx.google.com with ESMTPS id 6sm2187071qwd.12.2009.07.23.04.23.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 23 Jul 2009 04:23:09 -0700 (PDT) X-Mailer: Apple Mail (2.935.3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:113050 Archived-At: Hello Yamamoto-san, Did you mean to check the changes below into the branch? I *think* these are pretty safe, but it seems a bit close to release for such feature changes, even in the name of standardization. My vote would be to do these on trunk only for now. Also: ns_get_color(): Shouldn't the description comment for ns_get_color() be updated further? It looks like something was just chopped off, leaving the rest making little sense. What is the bug or problem this change fixes? ns_color_to_lisp(): The function could be simplified now that you have eliminated a special case. nsfont_draw(): Would setting the foreground instead of the background color to the bitmap constitute a corrected implementation? ns-set-background-alpha: The implementation you just removed was superior to that for (set-frame-parameter nil 'alpha ##): it does not alter the alpha of the titlebar, scrollbars, modeline, or text. This makes it usable, instead of a curiosity. It also provides access via an interactive function. The correct fix would be to improve the (set- frame-parameter) version, not remove this while no alternative exists for users. 2009-07-16 YAMAMOTO Mitsuharu * nsfns.m (Fns_set_alpha): Remove function. (syms_of_nsfns): Don't defsubr it. * nsterm.m (ns_get_color): Remove incompatible color formats. (ns_color_to_lisp): Generate #rrggbb color format string. 2009-07-15 YAMAMOTO Mitsuharu * nsfont.m (nsfont_draw): Remove code for stippling, which actually does tiling. * nsterm.m (ns_maybe_dumpglyphs_background): Likewise. 2009-07-16 YAMAMOTO Mitsuharu * term/ns-win.el (ns-set-alpha): Don't declare. (ns-set-background-alpha): Remove function.