From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: 'Lars Magne Ingebrigtsen' <larsi@gnus.org>, 5105@debbugs.gnu.org
Subject: bug#5105: 23.1; doc string of facemenu-set-face
Date: Mon, 1 Aug 2011 14:47:47 -0700 [thread overview]
Message-ID: <E7FD74EBB7DA4BD3BEE5E0DBBF1F288A@us.oracle.com> (raw)
In-Reply-To: <jwvhb60rfij.fsf-monnier+emacs@gnu.org>
> >> > What? Why are you arbitrarily deciding that? Why not
> >> > assume that allowing a string is a good thing, a
> >> > purposeful design decision?
> >>
> >> Because a good programmer knows that it's obviously not a
> >> good idea to encourage the caller to use a string here.
> >
> > It might be obvious to what you call good programmers, but
> > how about giving a _reason_, for us mere mortals?
>
> How 'bout the other way around: give me a reason to accept strings.
You're the one claiming that there is a good (even _obvious_) reason not to.
What's the reason, if it's so obvious?
> >>> We have many places in Emacs where we allow an arg to be
> >>> either a thing or its name. Think of all of the BUFFER args
> >>> that can be a buffer or a buffer name.
> >
> > What do the "good programmers" say about the design in
> > those cases? Is it "obviously not a good idea" also?
>
> Very often, yes it's also a bad idea.
Why? And when? ("Very often" doesn't say much - how about a specific context
where it is a bad idea, since there are supposedly so many.)
How about a reason or two to back up all the hand-waving claims about "good" and
"bad"?
> At least for buffers we have a guarantee that there is a
> one-to-one mapping between (live) buffers and buffer names,
> so for buffers it's a bit less bad.
"Less bad"? You haven't said what is bad about it.
And what about faces? Can a given face have two different names? We have
`face-name' the same way we have `buffer-name'. At least there is nothing
documented AFAICT about `face-name' being a relation and not a function.
If F is a face, under what circumstances will (face-name F) give different names
at different times?
next prev parent reply other threads:[~2011-08-01 21:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 16:49 bug#5105: 23.1; doc string of facemenu-set-face Drew Adams
2011-07-13 14:42 ` Lars Magne Ingebrigtsen
2011-07-13 15:39 ` Drew Adams
2011-07-15 16:06 ` Lars Magne Ingebrigtsen
2011-07-15 16:13 ` Drew Adams
2011-07-18 14:27 ` Stefan Monnier
2011-07-18 16:55 ` Drew Adams
2011-08-01 21:27 ` Stefan Monnier
2011-08-01 21:47 ` Drew Adams [this message]
2011-08-01 22:21 ` Lars Ingebrigtsen
2011-08-01 22:48 ` Drew Adams
2011-08-02 0:31 ` Stefan Monnier
2011-08-02 0:29 ` Stefan Monnier
2011-08-02 1:36 ` Drew Adams
2011-08-02 15:42 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E7FD74EBB7DA4BD3BEE5E0DBBF1F288A@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=5105@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.