From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jean-Christophe Helary Newsgroups: gmane.emacs.devel Subject: Re: lisp/term/ns-win.el modification Date: Thu, 4 May 2017 17:50:19 +0900 Message-ID: References: <44D4AA3B-8F87-42B6-A2D2-00487B066183@gmail.com> <74D20593-63B6-46FB-BAC3-D841D0BCD461@gmail.com> <0A49E755-3D18-48E8-81D4-253160F60A16@gmail.com> <40f503a4-49eb-a3ff-fe5f-993c8f346c33@lanl.gov> <15112485-03CC-4FFF-8A9D-BA28D2490A91@gmail.com> <42CDF1D0-015D-4F0D-A8A2-A55776D34FEE@gmail.com> <83inlmkmqq.fsf@gnu.org> <5d3d3f3d-e49e-2b83-0591-14b3e19f8cb0@gmail.com> <834lx5lxz6.fsf@gnu.org> <7A82B268-C40B-4D45-8973-68A2408F7F28@gmail.com> <83r309jdcj.fsf@gnu.org> <00A24BD4-FE6F-4098-A8DD-73240899FA13@gmail.com> <83efw9j6l0.fsf@gnu.org> <0FED46C2-B8D7-40B3-BEF0-1515E7E5DE9F@gmail.com> <83wpa0iold.fsf@gnu.org> <72ADB3FE-F9A6-4030-A4F8-84C60A42040C@gmail.com> <83vapkilx4.fsf@gnu.org> <72EA8A0D-F889-4AC9-8E5E-45C2956E5CAD@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_A05E7023-7FF4-4635-9B7C-7AF17C0C79A3" X-Trace: blaine.gmane.org 1493888403 24626 195.159.176.226 (4 May 2017 09:00:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 4 May 2017 09:00:03 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 04 10:59:54 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6Cc5-0006CZ-11 for ged-emacs-devel@m.gmane.org; Thu, 04 May 2017 10:59:53 +0200 Original-Received: from localhost ([::1]:40516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6CcA-0000Lm-Nf for ged-emacs-devel@m.gmane.org; Thu, 04 May 2017 04:59:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6CZ6-0005wc-Sz for emacs-devel@gnu.org; Thu, 04 May 2017 04:56:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6CZ3-0007ID-S1 for emacs-devel@gnu.org; Thu, 04 May 2017 04:56:48 -0400 Original-Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:32842) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d6CZ3-0007Hu-JP for emacs-devel@gnu.org; Thu, 04 May 2017 04:56:45 -0400 Original-Received: by mail-pf0-x242.google.com with SMTP id b23so1286915pfc.0 for ; Thu, 04 May 2017 01:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:date:references:to:in-reply-to:message-id; bh=Wh9ngfj1Bkest625i9YvEUrHRyYHy1fvra9HqSZfEz0=; b=KyJ4cfbG5QiANIpRG7iZgy8SeumGvGD4KsngiZ46DZoPEvOsIQCo4uUGxIMjT2Adri 8x2pwK0GTHwL/agjIeISB4hm3qm8o2xKE8+3b5W7lDVTKfqhgJkkufAceplu6zN/wluz JbnoqgWBXSIz2vk/PjjHFWAkTNBZEarECDdYW66Sfj2yr657aEV7fU+l8vb3/uf7ujZY 5hmA5SrYwNYf9MzfTUglSlOuMG0FxvqxSj2glGvNLB1NeDkXtrXlc8RZNFx+4n3RjrGF R25GT6mN6jCFCKYmsWx9YpfeT/nhgcn83fZlBKJyDg9FoLfBWP+dzBaUIqmkHDx35LuM tqHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:date:references:to :in-reply-to:message-id; bh=Wh9ngfj1Bkest625i9YvEUrHRyYHy1fvra9HqSZfEz0=; b=Af+Cn8na6zwAtKlJZOvgXJ7qF2S5Dc3qxcF5zViR0qGlWonbeh6ozpFCgfTULBMYhn U1js6ZmcMaOmRGisfuKFjXDdRLpN0vfTHoP6su9sMHiw9eSBHSoRtrf8+VgJgTOe212w szpxfhsyWt2GGzVAO6eKGOkyr/f3P8VWfpm0QlBNmeavMG5L2Iop6em8rEmgH+QaN5t4 W34clDQTo9to82s+7qAc/BOih/tt9m5H7KQcIuwHAPbKGOedKAytpPzOV7+2TW13KH/r GhERj6ha1ZvHXKwmQq3raaCiMO2Q4Zu0QMptfAu8Dd69K5MNbP+5HBcMlFCCcKOTPtO/ d2dQ== X-Gm-Message-State: AN3rC/4mm5BHbBeq095b5Sk9ITHLa7g/2vt+nyclu2iRRGrJxXBSZtBF vWG9O2mSV/AovWRaZb1JHQ== X-Received: by 10.98.79.28 with SMTP id d28mr5119078pfb.56.1493888204427; Thu, 04 May 2017 01:56:44 -0700 (PDT) Original-Received: from [192.168.100.109] (wmx2-pvt-209-133-255-123.kualnet.jp. [123.255.133.209]) by smtp.gmail.com with ESMTPSA id b68sm2774578pfa.127.2017.05.04.01.56.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 May 2017 01:56:43 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3273) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214560 Archived-At: --Apple-Mail=_A05E7023-7FF4-4635-9B7C-7AF17C0C79A3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Anders, Thank you for the verification. Would you mind checking that this patch = is correct before I propose it for a commit? The log message would be something like: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D Fix Multiline support in NS "open-file" service previous patch * lisp/term/ns-win.el (ns-open-file-service): removed a useless check = and fixed a typo. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D Jean-Christophe=20 --Apple-Mail=_A05E7023-7FF4-4635-9B7C-7AF17C0C79A3 Content-Disposition: attachment; filename=ns-win.el.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="ns-win.el.diff" Content-Transfer-Encoding: 7bit diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el index 2d173b2d80..4df5f0abe2 100644 --- a/lisp/term/ns-win.el +++ b/lisp/term/ns-win.el @@ -233,10 +233,9 @@ The properties returned may include `top', `left', `height', and `width'." (defun ns-open-file-service (filenames) "Open multiple files when selecting a multiline string FILENAMES." (let ((filelist (split-string filenames "[\n\r]+" t "[ \u00A0\t]+"))) - ;; The path strings are timmed for spaces, nbsp and tabs. + ;; The path strings are trimmed for spaces, nbsp and tabs. (dolist (filestring filelist) - (if (not (equal "" filestring)) - (dnd-open-file filestring nil))))) + (dnd-open-file filestring nil)))) (defun ns-spi-service-call () --Apple-Mail=_A05E7023-7FF4-4635-9B7C-7AF17C0C79A3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On May 4, 2017, at 5:40, Anders Lindgren wrote: >=20 > Hi! >=20 > I just tested your latest patch. The code looks much cleaner now when = you use `split-string'. (I didn't know it could all those tricks -- it's = always good to learn something new!) >=20 > The patch seems to work perfectly! >=20 > Some minor details: >=20 > * You no longer need the `(if (not (equal "" filestring"))' test -- = when the OMIT-NULLS argument is non-nil, `split-string' ensures that the = list doesn't contain empty strings. >=20 > * You misspelled "trimmed" as "timmed" in the comment in = `ns-open-file-service'. >=20 > -- Anders --Apple-Mail=_A05E7023-7FF4-4635-9B7C-7AF17C0C79A3--