From: Jean-Christophe Helary <jean.christophe.helary@gmail.com>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Re: lisp/term/ns-win.el modification
Date: Thu, 4 May 2017 17:50:19 +0900 [thread overview]
Message-ID: <E78DF86E-C246-4330-AB44-E5630E8354F9@gmail.com> (raw)
In-Reply-To: <CABr8ebY6EZLwGDC=Dohmk3vTpTZH_DDSycBHGMzaHRrR0z+eEw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
Anders,
Thank you for the verification. Would you mind checking that this patch is correct before I propose it for a commit?
The log message would be something like:
===========================
Fix Multiline support in NS "open-file" service previous patch
* lisp/term/ns-win.el (ns-open-file-service): removed a useless check and fixed a typo.
===========================
Jean-Christophe
[-- Attachment #2: ns-win.el.diff --]
[-- Type: application/octet-stream, Size: 739 bytes --]
diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el
index 2d173b2d80..4df5f0abe2 100644
--- a/lisp/term/ns-win.el
+++ b/lisp/term/ns-win.el
@@ -233,10 +233,9 @@ The properties returned may include `top', `left', `height', and `width'."
(defun ns-open-file-service (filenames)
"Open multiple files when selecting a multiline string FILENAMES."
(let ((filelist (split-string filenames "[\n\r]+" t "[ \u00A0\t]+")))
- ;; The path strings are timmed for spaces, nbsp and tabs.
+ ;; The path strings are trimmed for spaces, nbsp and tabs.
(dolist (filestring filelist)
- (if (not (equal "" filestring))
- (dnd-open-file filestring nil)))))
+ (dnd-open-file filestring nil))))
(defun ns-spi-service-call ()
[-- Attachment #3: Type: text/plain, Size: 632 bytes --]
> On May 4, 2017, at 5:40, Anders Lindgren <andlind@gmail.com> wrote:
>
> Hi!
>
> I just tested your latest patch. The code looks much cleaner now when you use `split-string'. (I didn't know it could all those tricks -- it's always good to learn something new!)
>
> The patch seems to work perfectly!
>
> Some minor details:
>
> * You no longer need the `(if (not (equal "" filestring"))' test -- when the OMIT-NULLS argument is non-nil, `split-string' ensures that the list doesn't contain empty strings.
>
> * You misspelled "trimmed" as "timmed" in the comment in `ns-open-file-service'.
>
> -- Anders
next prev parent reply other threads:[~2017-05-04 8:50 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 4:50 lisp/term/ns-win.el modification Jean-Christophe Helary
2017-04-27 9:02 ` Anders Lindgren
2017-04-27 10:13 ` Jean-Christophe Helary
2017-04-27 11:30 ` Anders Lindgren
2017-04-27 14:53 ` Jean-Christophe Helary
2017-04-27 15:09 ` Davis Herring
2017-04-27 15:31 ` Jean-Christophe Helary
2017-04-27 23:32 ` Jean-Christophe Helary
[not found] ` <15112485-03CC-4FFF-8A9D-BA28D2490A91-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-28 1:49 ` Jean-Christophe Helary
2017-04-29 12:24 ` Anders Lindgren
[not found] ` <CABr8ebaB1Fp0BgVy7LWwtOnSs1UOXr3CJumMfOWR4JOooQMT4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-29 12:49 ` Jean-Christophe Helary
2017-04-30 5:36 ` Anders Lindgren
2017-04-30 12:14 ` Noam Postavsky
2017-04-30 6:41 ` Jean-Christophe Helary
2017-04-30 14:12 ` Eli Zaretskii
2017-04-30 15:06 ` Clément Pit-Claudel
2017-04-30 15:24 ` Eli Zaretskii
2017-04-30 22:28 ` Jean-Christophe Helary
2017-05-01 6:33 ` Eli Zaretskii
2017-05-01 8:23 ` Jean-Christophe Helary
2017-05-01 8:59 ` Eli Zaretskii
2017-05-01 10:53 ` Jean-Christophe Helary
2017-05-01 11:27 ` Eli Zaretskii
2017-05-02 4:00 ` Jean-Christophe Helary
2017-05-02 6:44 ` Eli Zaretskii
2017-05-02 6:47 ` Jean-Christophe Helary
2017-05-01 15:12 ` Jean-Christophe Helary
2017-05-01 15:27 ` Eli Zaretskii
2017-05-01 15:58 ` Jean-Christophe Helary
2017-05-01 16:25 ` Eli Zaretskii
2017-05-02 12:57 ` Jean-Christophe Helary
2017-05-03 20:40 ` Anders Lindgren
2017-05-04 0:10 ` Jean-Christophe Helary
2017-05-04 8:50 ` Jean-Christophe Helary [this message]
2017-05-04 18:37 ` Anders Lindgren
2017-05-05 8:36 ` Jean-Christophe Helary
2017-04-30 22:23 ` Jean-Christophe Helary
2017-05-01 6:30 ` Eli Zaretskii
2017-04-27 12:24 ` Noam Postavsky
2017-04-27 14:53 ` Jean-Christophe Helary
2017-04-27 12:51 ` mituharu
2017-04-27 14:55 ` Jean-Christophe Helary
2017-04-27 15:35 ` Jean-Christophe Helary
2017-04-27 18:28 ` mituharu
2017-04-27 23:29 ` Jean-Christophe Helary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E78DF86E-C246-4330-AB44-E5630E8354F9@gmail.com \
--to=jean.christophe.helary@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.