How to update major modes?

How to update major modes?

[Jared Craig Ahern]

Hello!

I use emacs all the time, mainly to edit LaTeX and Fortran 95/2003 files 
(also make and python). I have noticed that some of the keywords that I 
commonly used are not recognized by emacs, which causes minor annoyances 
such as missing syntax highlighting (e.g. 'protected' in Fortran) or 
attempting to spellcheck within labels (e.g. '\autoref{}' in 
LaTeX/hyperref).

Not being familiar with how to help out on GNU projects, what is the best 
way for me to contribute minor changes to some of the major mode lisp 
files?  Do I have to assign copyright and checkout the CVS tree, or can i 
just email snibbets somewhere?  Does, for example, f90.el or tex-mode.el 
have specific maintainers that I should talk to?

Also, if these problems are solved by a feature that I am not aware of, 
or if I missed something explaining how to do subissions on the 
website or wiki, please let me know.  Sorry if I'm asking an obvious 
question.

Thanks!
Jared

Re: How to update major modes?

[Glenn Morris]

Jared Craig Ahern wrote:

> I use emacs all the time, mainly to edit LaTeX and Fortran 95/2003 files 
> (also make and python). I have noticed that some of the keywords that I 
> commonly used are not recognized by emacs, which causes minor annoyances 
> such as missing syntax highlighting (e.g. 'protected' in Fortran) or 

For the specific case of Fortran, just post the missing F2003 keywords
(it recognizes all the F95 ones AFAIK) and I'll add them.

> Not being familiar with how to help out on GNU projects, what is the best 
> way for me to contribute minor changes to some of the major mode lisp 
> files?  Do I have to assign copyright and checkout the CVS tree, or can i 
> just email snibbets somewhere? 

You can post feature requests and patches here or on emacs-devel.
We can use trivial patches without assignment; if we want to use a
larger one we'll ask you for an assignment.

The file etc/CONTRIBUTE in the CVS has more details.

http://cvs.savannah.gnu.org/viewvc/emacs/etc/CONTRIBUTE?root=emacs&view=markup

> Does, for example, f90.el or tex-mode.el have specific maintainers
> that I should talk to?

Me for the former, but it's much better to post to one of the mailing
lists rather than direct to the maintainer (who is usually listed at
the start of the .el file)

Re: How to update major modes?

[Michaël Cadilhac]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

Jared Craig Ahern <jahern@MIT.EDU> writes:

> Not being familiar with how to help out on GNU projects, what is the
> best way for me to contribute minor changes to some of the major mode
> lisp files?

Thanks for your concern in improving Emacs!

If you only plan to make minor changes, such as the one you mentioned,
you don't need a copyright assignment.  When you'll start to give
contributions that are more than, say, 20 lines, you'll have to get the
legal paper on, but for now on, it's OK ; you just modify the file, and
post the patches at emacs-devel@gnu.org.  Your proposal is then reviewed
and discussed, and if it's OK, it will be installed.

Welcome in the GNU world, where `free' stands for `freedom'! :-)

-- 
 |   Michaël `Micha' Cadilhac       |  Boobs will come and go, and then,     |
 |   http://michael.cadilhac.name   |  someday, you'll meet a pair of boobs  |
 |   JID/MSN:                       |           that you want to marry.      |
 `----  michael.cadilhac@gmail.com  |          -- Randy                 -  --'

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: How to update major modes?

[Richard Stallman]

    If you only plan to make minor changes, such as the one you mentioned,
    you don't need a copyright assignment.  When you'll start to give
    contributions that are more than, say, 20 lines, you'll have to get the
    legal paper on,

Actually, we would also need papers for a collection of minor changes
that add up to 15 or so real lines of text.

Re: How to update major modes?

[Jared Ahern]

OK!  Thanks for the input.  I'm pretty busy for the next few days,  
but I'll put together any changes that I think of, see how long they  
end up being, and then go about the proper way of submitting them.   
Be back soon.

Thanks again!
- Jared

Re: How to update major modes?

[Glenn Morris]

Glenn Morris wrote:

> For the specific case of Fortran, just post the missing F2003 keywords
> (it recognizes all the F95 ones AFAIK) and I'll add them.

I've just added a lot (not yet all) of Fortran 2003 syntax to the
development version of f90.el.

http://cvs.savannah.gnu.org/viewvc/emacs/lisp/progmodes/f90.el?root=emacs&view=markup

Re: How to update major modes?

[Jared Ahern]

Hey, that's great!  Sorry, I've been traveling and haven't had a  
chance to work on this yet.  The only things that I happen to notice  
(I haven't looked for too many keywords) are:

1) On initialization expressions, all of the stuff on the RHS of the  
'=' sign are in the same color - I'm not sure if it would be better  
to hilite the keywords, etc...
2) DEFAULT when it follows CASE is a keyword, or close enough
3) ... same with IN/OUT/INOUT in INTENT() expressions
4) Syntax coloring may fail across lines continued with '&'
5) TYPE(...) declarations are now hilited (great!), but this is done  
differently than REAL() and INTEGER(); I'd much prefer this over  
nothing, so not a huge deal.
6) INTRINSIC (and NON_INTRINSIC ?) kills the rest of the normal  
syntax hiliting on a USE statement; also not a big problem

Thanks for working on this!  I figured I was about the only one who  
cared about the Fortran mode these days.  The list above are just my  
thoughts; I'll work on them at some point if you are too busy, unless  
someone disagrees with my take on things.  I don't mean to make  
demands or anything.

On a side note, in TeX-mode, you can insert '\end{...whatever...}'  
with C-C C-E, much like typing 'END' and then TAB in F90.  How would  
I bind the latter to the former's key combo in my .emacs?  I keep  
going back and forth doing the wrong one...

Thanks!
Jared

On Oct 22, 2007, at 4:22 AM, Glenn Morris wrote:

> Glenn Morris wrote:
>
>> For the specific case of Fortran, just post the missing F2003  
>> keywords
>> (it recognizes all the F95 ones AFAIK) and I'll add them.
>
> I've just added a lot (not yet all) of Fortran 2003 syntax to the
> development version of f90.el.
>
> http://cvs.savannah.gnu.org/viewvc/emacs/lisp/progmodes/f90.el? 
> root=emacs&view=markup

f90-mode [was Re: How to update major modes?]

[Glenn Morris]

Jared Ahern wrote:

> 1) On initialization expressions, all of the stuff on the RHS of the  
> '=' sign are in the same color

It's always worked like that, and I don't think I'd want to change this.

> 2) DEFAULT when it follows CASE is a keyword, or close enough

That would be easy to change, but it's always been the way it is.

> 3) ... same with IN/OUT/INOUT in INTENT() expressions

Same as previous.

I think 2) and 3) are really things for your .emacs file.

> 4) Syntax coloring may fail across lines continued with '&'

Sure, you can always write the code in such a way as to fool
font-locking. Trying to support statements split over lines would be a
lot of extra work for little gain, IMO.

> 5) TYPE(...) declarations are now hilited (great!), but this is done  
> differently than REAL() and INTEGER(); I'd much prefer this over  
> nothing, so not a huge deal.

You mean in something like:

type(sometype) :: foo

you would prefer only the "type" part to be highlighted, not the whole
"type(sometype)"? Yes, I wondered about this too. It would in some
sense be more consistent with something "integer(kind=foo)" and is
easy to do. But the way it works now is how it was originally supposed
to work, until some typo crept in and broke it at some point.

> 6) INTRINSIC (and NON_INTRINSIC ?) kills the rest of the normal  
> syntax hiliting on a USE statement;

Should be fixed now.

> I don't mean to make demands or anything.

Not at all. It's nice to get some feedback.

> On a side note, in TeX-mode, you can insert '\end{...whatever...}'  
> with C-C C-E, much like typing 'END' and then TAB in F90.  How would  
> I bind the latter to the former's key combo in my .emacs?

I guess you want:

(defun my-f90-mode-hook ()
  (local-set-key "\C-c\C-e" 'f90-match-end))

(add-hook 'f90-mode-hook 'my-f90-mode-hook)