From: John Wiegley <jwiegley@gmail.com>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99834: Minor fixes to a recent contribution to ido.el
Date: Tue, 6 Apr 2010 16:02:15 -0400 [thread overview]
Message-ID: <E5C479C1-4749-4528-8C36-7B29A782B497@gmail.com> (raw)
In-Reply-To: <h2mf7ccd24b1004060343r4263a880r32787bca57cf168d@mail.gmail.com>
On Apr 6, 2010, at 6:43 AM, Juanma Barranquero wrote:
> On Tue, Apr 6, 2010 at 05:38, <jwiegley@gmail.com> wrote:
>
>> (ido-virtual-buffers): Moved defvar to fix byte-compiler warning.
>
> I had moved the defvar near the beginning of the buffer (in the
> "Temporary storage" section of ido's variables) and added a docstring,
> so now one of them is redundant.
I missed that while checking my diffs, even though I had seen your commit. I've removed the duplicate and kept your definition.
John
prev parent reply other threads:[~2010-04-06 20:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Nz0EA-00030W-Cd@internal.in.savannah.gnu.org>
2010-04-06 10:43 ` [Emacs-diffs] /srv/bzr/emacs/trunk r99834: Minor fixes to a recent contribution to ido.el Juanma Barranquero
2010-04-06 20:02 ` John Wiegley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E5C479C1-4749-4528-8C36-7B29A782B497@gmail.com \
--to=jwiegley@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.