From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#60407: [PATCH] Update go-ts-mode to use Imenu facility Date: Sun, 01 Jan 2023 22:31:31 +0000 Message-ID: References: <83y1qm39o3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29708"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Yuan Fu , 60407@debbugs.gnu.org To: Evgeni Kolev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 01 23:32:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pC6sK-0007Ww-7R for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Jan 2023 23:32:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pC6s8-000505-I4; Sun, 01 Jan 2023 17:32:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC6s6-0004zv-VG for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 17:32:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pC6s6-0000bm-MS for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 17:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pC6s6-0003sH-2v for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 17:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jan 2023 22:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60407 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60407-submit@debbugs.gnu.org id=B60407.167261230414868 (code B ref 60407); Sun, 01 Jan 2023 22:32:02 +0000 Original-Received: (at 60407) by debbugs.gnu.org; 1 Jan 2023 22:31:44 +0000 Original-Received: from localhost ([127.0.0.1]:41967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC6ro-0003rk-HP for submit@debbugs.gnu.org; Sun, 01 Jan 2023 17:31:44 -0500 Original-Received: from mail-4022.proton.ch ([185.70.40.22]:11967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC6rm-0003rQ-Fa for 60407@debbugs.gnu.org; Sun, 01 Jan 2023 17:31:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1672612295; x=1672871495; bh=iq+sx+raPGlzPxbKSsum4DB2x48llhabs1icPxh9rsw=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ZPauOYD5MsuhgWqke5H9He+SLhaVSeE2tHmkOwKNmU04Y3SGc2sMjKsGrWmF6M55u eZHoZeRra+7tePTJECtOqJkCq9pGjKHQb4Z47KUQBoANYiZeyfnXariXmJhQjkd3XV QLzDoYlLf04GRrsGtl7WxJgQsLRyzcHWJVaEcX9Fg44d51cYF4KeAKRlbA/4S93vA7 5XjIC74odYNjO7tZuhyygK7nE1hV9yaifedCqrVnJwa59pkgQSvKUruuHmVit2OAQn qrovDoQ7E3qufdG7MptXAUGaCHPYBQinaeEvVCAXJTTTxIYhjtnBgL9PQsdBhh75xC itAvIHDahwk2g== In-Reply-To: Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252291 Archived-At: On Sunday, January 1st, 2023 at 12:08, Evgeni Kolev wr= ote: >=20 > As I mentioned in the start of the mail thread - go-ts-mode's Imenu > puts Go interfaces and structs in the same "Type" bucket. This can be > improved in go-ts-mode. >=20 > I'm providing a second patch below which splits the interfaces and > structs into their own Imenu categories. >=20 > Please let me know if I should provide the second patch later, in a > separate thread, after the first patch is finished. I'm assuming it's > simpler to review the patches together. If it's not - I'll provide > them in a way to make the review easier, just let me know. > Hi Evgeni! Thanks for working on this, and apologies for the delay. The patches look good to me and work well, except for one issue (and a few = minor nits) mentioned below. All in one patch is probably best. - Type definitions are no longer captured. For example: type Quack int Does not show up anymore. - go-ts-mode--struct-node-p's docstring is missing a period at the end. - In go-ts-mode--interface-node-p and go-ts-mode--struct-node-p's docstring= s, I'm not sure it's worthwhile to mention "Go". Just interface and struct = should be fine. - Should the commit message mention changes to go-ts-mode (as in the actual= define-derived-mode mode part)?