From: "Drew Adams" <drew.adams@oracle.com>
To: 9934@debbugs.gnu.org
Subject: bug#9934: 24.0.91; `region-active-p' definition
Date: Tue, 1 Nov 2011 10:12:45 -0700 [thread overview]
Message-ID: <E4083662D2EA49498479318413BE7DF8@us.oracle.com> (raw)
The definition:
(defun region-active-p () "..."
(and transient-mark-mode mark-active))
Makes no sense, AFAICT. The mark *cannot* be active unless
`transient-mark-mode' is non-nil. The very definitions of "active" mark
and "active" region imply transient mark mode. When transient mark mode
is off, the region and mark are *never* active - the notion of "active"
does not exist in that context.
And since the correct definition: (defun region-active-p () mark-active)
is so trivial, this function should just be removed.
When is there ever any reason to test (and transient-mark-mode
mark-active)? When is that value ever different from just the value of
mark-active?
In GNU Emacs 24.0.91.1 (i386-mingw-nt5.1.2600) of 2011-10-30 on MARVIN
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.6) --no-opt --cflags
-I"D:/devel/emacs/libs/libXpm-3.5.8/include"
-I"D:/devel/emacs/libs/libXpm-3.5.8/src"
-I"D:/devel/emacs/libs/libpng-dev_1.4.3-1/include"
-I"D:/devel/emacs/libs/zlib-dev_1.2.5-2/include"
-I"D:/devel/emacs/libs/giflib-4.1.4-1/include"
-I"D:/devel/emacs/libs/jpeg-6b-4/include"
-I"D:/devel/emacs/libs/tiff-3.8.2-1/include"
-I"D:/devel/emacs/libs/gnutls-2.10.1/include" --ldflags
-L"D:/devel/emacs/libs/gnutls-2.10.1/lib"'
next reply other threads:[~2011-11-01 17:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 17:12 Drew Adams [this message]
2011-11-01 17:59 ` bug#9934: 24.0.91; `region-active-p' definition Andreas Schwab
2011-11-01 18:13 ` Drew Adams
2011-11-01 18:50 ` Andreas Schwab
2011-11-01 19:43 ` Drew Adams
2011-11-01 20:42 ` Andreas Schwab
2011-11-01 22:26 ` Drew Adams
2011-11-01 22:45 ` Andreas Schwab
2011-11-01 20:09 ` Stefan Monnier
2011-11-01 22:26 ` Drew Adams
2011-11-02 1:26 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E4083662D2EA49498479318413BE7DF8@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=9934@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.