all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: "Michael R. Mauger" <michael@mauger.com>, 38813@debbugs.gnu.org
Subject: bug#38813: Make comint-tests more robust
Date: Mon, 30 Dec 2019 17:19:08 +0100	[thread overview]
Message-ID: <E3E94B24-AC57-4098-8BAC-B1B438220567@acm.org> (raw)
In-Reply-To: <878smtvo01.fsf@gmx.de>

30 dec. 2019 kl. 16.20 skrev Michael Albinus <michael.albinus@gmx.de>:

> The usual pattern is (while (accept-process-output proc 0 nil t))
> That's what I do in tramp-tests.el

Thank you, but that only works if inside another loop, and then it is a busy-wait, right?
We don't really have a predicate to tell us when we need to stop waiting, unless we use the test condition for that.
We could do

 (while (accept-process-output proc 0.1 nil t))

which isn't strictly necessary since the test logic guarantees that only two accept-process-output calls should be needed, but it doesn't hurt (much).






  reply	other threads:[~2019-12-30 16:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-30 13:57 bug#38813: Make comint-tests more robust Mattias Engdegård
2019-12-30 15:20 ` Michael Albinus
2019-12-30 16:19   ` Mattias Engdegård [this message]
2019-12-30 18:28     ` Michael Albinus
2019-12-30 20:05       ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E3E94B24-AC57-4098-8BAC-B1B438220567@acm.org \
    --to=mattiase@acm.org \
    --cc=38813@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=michael@mauger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.