From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Sat, 31 Dec 2022 11:32:54 +0100 Message-ID: References: <83v8ls6gvb.fsf@gnu.org> <07332CE6-C6A9-469A-9C41-B47841D8798D@secure.kjonigsen.net> <87r0wgpu3g.fsf@thornhill.no> <7e522fe6-2e5a-5bca-10b1-5a19862dcea2@secure.kjonigsen.net> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39917"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60376@debbugs.gnu.org, casouri@gmail.com To: jostein@kjonigsen.net, Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 31 11:33:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBZB3-000AAE-CE for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Dec 2022 11:33:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBZAn-0002Av-3f; Sat, 31 Dec 2022 05:33:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBZAk-0002AQ-Co for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 05:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pBZAk-0008Dw-0e for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 05:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pBZAj-0008AR-R3 for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 05:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Dec 2022 10:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60376 X-GNU-PR-Package: emacs Original-Received: via spool by 60376-submit@debbugs.gnu.org id=B60376.167248277931387 (code B ref 60376); Sat, 31 Dec 2022 10:33:01 +0000 Original-Received: (at 60376) by debbugs.gnu.org; 31 Dec 2022 10:32:59 +0000 Original-Received: from localhost ([127.0.0.1]:36601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBZAg-0008AB-Qd for submit@debbugs.gnu.org; Sat, 31 Dec 2022 05:32:59 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]:45694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBZAe-00089y-K7 for 60376@debbugs.gnu.org; Sat, 31 Dec 2022 05:32:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1672482774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3bqM4fpcadK9gAbV8ZH/SDD8t9B1IMWO02SVDvGX6fw=; b=MsJu7BFW63bZQpCueVd0HWB231KMZ5bE50s1wcLlWQtaXEAMH3USp+oHiUqfLceMvETP8Q ANfROocVHJgqi7v0Pp8rzPmMB8g8jD3+jtiXo9Qzw6KNDPAbRw7CeOFhaj39s+dIEefbMY QStHKPfk5k/rcj8jHyV9yVbDLDu6J7DSpRXpojj7CdtcdEdNH4eUNKR3rHtAxaij+D/ghO 4nTv1aZwXwXik/5+Mk1FvFxZwAAxOP8D7oqxC/N44n1ONMOXJaVBGqW74/9MKBxQWwG7EO e0fG6aLunl/ZGNwCXvq73Yb/zD8dG6ioj1SXnBXInnNE4RgNUfOpHkvwg5bWaA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <7e522fe6-2e5a-5bca-10b1-5a19862dcea2@secure.kjonigsen.net> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252181 Archived-At: On 31 December 2022 10:53:54 CET, "Jostein Kj=C3=B8nigsen" wrote: >On 30=2E12=2E2022 20:30, Theodor Thornhill wrote: >> Jostein Kj=C3=B8nigsen writes: >>=20 >>>> On 30 Dec 2022, at 16:46, Eli Zaretskii wrote: >>>>=20 >>>> =EF=BB=BF >>>>> Date: Fri, 30 Dec 2022 15:39:20 +0100 >>>>> Cc: casouri@gmail=2Ecom, 60376@debbugs=2Egnu=2Eorg, theo@thornhill= =2Eno >>>>> From: Jostein Kj=C3=B8nigsen >>>>>=20 >>>>> To be clear: I think csharp-ts-mode works well beyond 85% (it's what= I >>>>> use as my daily driver), but the syntax-highlighting at level 3 may = be >>>>> more excessive than some people (like Stefan) prefer=2E >>>>>=20 >>>>> If we instead for these "major" changes suggested by Yuan, instead a= im >>>>> for just moving some "smaller" implementation-detail >>>>> (function-invocations and property-highlighting) to level 4, I think= we >>>>> she be able to get something which is mostly what Stefan would expec= t >>>>> and prefer, and it would be a much smaller change=2E >>>>>=20 >>>>> Then we can take a look at those bigger changes (standardized featur= es, >>>>> enabling/disabling them individually, as end-users, etc) for Emacs-3= 0=2E >>>>>=20 >>>>> I think that's a more realistic plan=2E Does that sound OK? >>>> Yes, it does=2E And I urge you to submit patches to that effect=2E >>>>=20 >>>> Thanks=2E >>> Theo has offered to come up with some patches and I=E2=80=99ll do my b= est to battle-test them=2E >>>=20 >>> Hopefully we can get this done quickly enough to suit your taste ;) >>>=20 >> Let's start here! >>=20 >> If you're satisfied, Jostein, report back, then you install, Yuan? >>=20 >> Then rinse repeat :-) >>=20 >> Theo > >I've tested it, and I can't say I see any regressions=2E > >Two things though: > >- Method-invocations are still getting fontified on level 3=2E I believe = Stefan wanted this to be on level 4? > >- I see we've missed fontification of method-invocations on self-methods = (this=2EDoSomething()) entirely=2E > >If we fix the first thing, I guess the second one is also doable? :) > >-- >Jostein > Great! Yuan or Eli, will you install? I'll follow up with more stuff later= :) Theo