From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: Emacs macOS build warnings Date: Sun, 6 Feb 2022 17:14:07 +0100 Message-ID: References: <968F1C8D-123F-4692-B035-C999767CC45C@acm.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18379"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , Emacs-Devel To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 06 17:15:45 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGkCW-0004cJ-Of for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Feb 2022 17:15:44 +0100 Original-Received: from localhost ([::1]:57758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGkCV-0007cV-N1 for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Feb 2022 11:15:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGkBE-0006tP-Lw for emacs-devel@gnu.org; Sun, 06 Feb 2022 11:14:25 -0500 Original-Received: from mail213c50.megamailservers.eu ([91.136.10.223]:39966 helo=mail194c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGkBA-0003Hx-23 for emacs-devel@gnu.org; Sun, 06 Feb 2022 11:14:24 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1644164054; bh=ZBn2wb1dV5FZ3jZRv8lVgSVCE0i4sacyMajK2zdNjWs=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=ruPDtzrKqiVljWDGTgXrT1dHZpI9TPDctdAj4r/CX6D23hVdGNe/kk613PkjS1xLI WUfpnHi8OPp+CDv7HUfHUCRnrYnNIhWTdDKxtXOImFY9c1JMkXDw+ZJLzcu8eSge+M c8JxaNK713r9TSK9xzQfRIajlPCI/3KlbgucJs3U= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 216GE7Wb011088; Sun, 6 Feb 2022 16:14:12 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F26.61FFF3D6.000F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.10.223; envelope-from=mattiase@acm.org; helo=mail194c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285980 Archived-At: 6 feb. 2022 kl. 17.00 skrev Alan Third : > On the latest macOS I believe vfork now does the same thing as fork, > so it might be easiest to detect the OS version and unset HAVE_VFORK, > although since we don't seem to actually check for that directly in > configure.ac I guess it's perhaps a standard test in autoconfig which > may make it hard to over-ride? In the version I am using (11.6.3), which is also the most recently = supported for my machine, vfork is measurably faster than fork so it = isn't an alias yet. In other words, unsetting HAVE_VFORK would lead to a = performance regression. > The alternative approach is to look at whether we should be using > posix_spawn here. I was under the impression that we had already > switched to using posix_spawn, at least on macOS, so I guess these > calls to vfork were missed. The idea is to use posix_spawn when possible; according to comments in = the code, that function cannot be used in some circumstances such as = when we need to use PTYs instead of pipes. I haven't verified whether = this is actually true. I'm sure you are happy to hear that dropping fork/exec is high on my = list of things to discuss with Ken and Dennis when I finally get my time = machine working. >> I treated CTGetCoreTextVersion warning by following the direction in >> the deprecation message and used NSProcesInfo instead, and it seems >> to work although it's a bit clumsy. Is there a better way? >=20 > I think your fix for this is good and probably the right thing to do. Thank you, I shall commit it as a separate change then.