From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?iso-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] About the :distant-foreground face attribute Date: Tue, 14 Jan 2014 23:05:48 +0100 Message-ID: References: <87bnzo9cja.fsf@gnu.org> <59B7E7FC-48D0-4737-B1BB-FFAC5BA9E07A@swipnet.se> <874n5f3162.fsf@gnu.org> <83fvozf86g.fsf@gnu.org> <87r48javwe.fsf@gnu.org> <83bnzmfjxe.fsf@gnu.org> <52D3E689.6050902@dancol.org> <8E16225F-53EF-498A-AB35-66EB9B33B859@swipnet.se> <52D43360.6050605@dancol.org> <9BD01B88-AF13-44DD-8DBE-4598BAC136DD@swipnet.se> <52D45C73.6090906@dancol.org> <52D4EBA9.8050802@swipnet.se> <52D4F2C2.8080800@dancol.org> <52D504A7.80104@swipnet.se> <52D514FF.7010404@dancol.org> <52D52312.6070106@swipnet.se> <52D58632.3010106@dancol.org> <381DEBDC-71D8-4FAC-BA55-897FEC73A2FC@swipnet.se> <52D598AF.9050306@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1389737184 20211 80.91.229.3 (14 Jan 2014 22:06:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Jan 2014 22:06:24 +0000 (UTC) Cc: Eli Zaretskii , Chong Yidong , emacs-devel To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 14 23:06:26 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W3C7q-0007SW-55 for ged-emacs-devel@m.gmane.org; Tue, 14 Jan 2014 23:06:22 +0100 Original-Received: from localhost ([::1]:50903 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3C7p-0003KW-2q for ged-emacs-devel@m.gmane.org; Tue, 14 Jan 2014 17:06:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3C7f-0003Jn-R3 for emacs-devel@gnu.org; Tue, 14 Jan 2014 17:06:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3C7Z-0002Au-Ag for emacs-devel@gnu.org; Tue, 14 Jan 2014 17:06:11 -0500 Original-Received: from mailfe02.swip.net ([212.247.154.33]:58452 helo=swip.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3C7L-00028Q-PP; Tue, 14 Jan 2014 17:05:51 -0500 X-T2-Spam-Status: No, hits=0.8 required=5.0 tests=BAYES_50 Original-Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe02.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 469183470; Tue, 14 Jan 2014 23:05:48 +0100 In-Reply-To: <52D598AF.9050306@dancol.org> X-Mailer: Apple Mail (2.1827) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 212.247.154.33 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168401 Archived-At: 14 jan 2014 kl. 21:06 skrev Daniel Colascione : > On 01/14/2014 12:01 PM, Jan Dj=E4rv wrote: >>=20 >> No. If Emacs generates a color, Emacs desides what looks good. If >> the system defines a color, the system (or the user if customized) >> desides what looks good. I don't think it matters what I think about >> colors generated by your patch, I might even think they look better >> than many system defined colors. But as a principle I think the >> desision is not Emacs to make *by default*. Users may of course >> apply customizations to Emacs and change it. >=20 > In 24.4, Emacs has already been changed to override the system = selection foreground color with various font-lock faces. Which font lock faces are you talking about? No system I know of = defines system colors for things like comment face, function face etc. > Why is it okay to do that when there's no contrast problem, but = suddenly, when there's a contrast problem, we can say that the principle = of following system colors is important? The principle of following system foreground is only important if system=20= background is used. This is currently for NS/Gtk+ only. For Lucid/Motif/No toolkit, we = don't use system colors at all, because they are not known and can not be known,=20= because the API to get them is not available. > You're applying this principle very selectively. System background + contrast problem =3D> system foreground. How is that selectively, it is a clear rule. > If you're going to override the system color selection, you need to do = it well and consistently, and automatic contrast adjustment is the best = way to go about solving the inevitable contrast problems that arise when = you combine colors you control with colors you don't. Again, I don't know what faces except region faces a system defines = colors=20 for, so when you say Emacs overrides system colors for font-lock faces, = I=20 don't know what faces you are talking about. If there are system colors that are applicable as font-lock face colors, = then=20 that is news to me. Jan D.