From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Select completions from the minibuffer Date: Sat, 19 Mar 2022 21:43:29 +0100 Message-ID: References: <87ee3714li.fsf@gnus.org> <86r1773sb4.fsf@mail.linkov.net> <87pmmquew4.fsf@gnus.org> <86ee357wob.fsf@mail.linkov.net> <20220314090826.gyc42227jpvh4efa@Ergus> <86zglsiazs.fsf@mail.linkov.net> <20220317184701.ani7k3clp3impqwn@Ergus> <865yoc47d2.fsf@mail.linkov.net> <20220317231027.65clapwxz5qtnpm4@Ergus> <86y217d2j3.fsf@mail.linkov.net> <20220318213112.7vfzpsxqvd2md4jt@Ergus> <86v8w9u55t.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=----T2DTOT6CHSOSCWLNBNQHZVCEOXDMLW Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23008"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org, Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 19 21:44:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVfwI-0005kt-QU for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Mar 2022 21:44:42 +0100 Original-Received: from localhost ([::1]:58718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVfwH-0006hZ-CF for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Mar 2022 16:44:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVfvO-0005wy-3P for emacs-devel@gnu.org; Sat, 19 Mar 2022 16:43:46 -0400 Original-Received: from sonic301-3.consmr.mail.bf2.yahoo.com ([74.6.129.42]:35480) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVfvL-0007y3-C1 for emacs-devel@gnu.org; Sat, 19 Mar 2022 16:43:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1647722621; bh=Agtr+ozQo8YaprVBpUkEI4Z/dZepmhLO4Yk4ts5zJaA=; h=Date:From:To:CC:Subject:In-Reply-To:References:From:Subject:Reply-To; b=G5Y8cTeMm7L4q7CT8LizCQM5NU/6LoxjqOFQrJ7q8Z8kUlYLlxjD16/Fzte2vThNKVDvJ0A6gmLMlP98cnua47It3EcSiuWftrvnLwRBk8UT87Z9ttxK8myZDnx4DH9m2vnJDNql/21qWALMn0I+U43zo8P6Ht7ZiUGNH3EB7pyqd2FNSZfF5aDXDMLN+iUhHvoo/lUyETcN8xlofeYRJeoEBf8BuQ9OzyiAoYG4DmCEbm+QurZOcU2t+EFZ6uUOECRz69fUxwvcw/xqtndHX8r3irLk9ASyAJ/Ed/jIz/WwZEmQxQv1mwijhMbxuNjQTzErDEpTWj3ZN39O4gc89w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647722621; bh=5d4S1CjIEiqegEX5RkW3ZitFdPoPBIMEwOcugYNQXpB=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=N8TzyfCH/KBaiy/UuX9S5l31ifKJVg5zYjGNRO2gGRUWBVZeeoTAHb0YXaCfcWt7IuFJ3t47YAZ8dMZKGAGfq1nwPSnAMbfoJd73V5XNyLqzamTR4AAKX78nOvzpoS8ggH+WHrOHTCNT8qajRM1Ul5b8Tb6eu0mEVzjvJsy3dNwAh1wxX8rdYn8ZQarJagehcbsmbUQbTdXXlbgTic8Tddc2vs9CAt09RXkCx2vsngpoNnpupmDE/TlPNVSgPjaO6YPns+hBZrfRYa7GSB/dcbvCYFMQZLZO1VgmIMFZXzjhl/MkEFxRMdWog20fgF/45sjJRizXe9gyzwN50SJLNw== X-YMail-OSG: DxgWIlcVM1lgHRKgmX9LsHUzv.HA3cwSdTGTwtTGdPzwMODHSvr1m5XgQloOiRv QNe3m4YCmR5hw5oDxS2ObIxy3ZW3c0v1yt1pZ8RJinTja0Z_F7L02RMndrlXS3hX.rwV5d0l3j4N syroS8bjhrX1ELddelidQ8TXOHWp7bra35KNoZVku4zqR3DsDL.1IxziAPZKjQlo7AAXO.5iCIuw Mf6mLeItSHj48FEQC5TEmYGeqPxWD3siI3fLWNyOwkKSdaJyFZ1fAzKe6LVjAvD.qCBIFdUvRiVz hsCk_IGoFLIhcFB_sFD7tLhHS059D4tW9SOHXLdVUagw4dZLtVXnoQaX7pBQyxFT2PUJ.mDVQfy1 VEj_C7juzvtucAwgQ0qoVxp3gyDbtqdTSWyb.uzHxKKJKX9oH5dtoAWjf4kg5VYmzivtqgfdFQvI MYkeZauyC0WCUAmzNAeNKRcQuxDTHZIVBSoLjkbI0W7136hypf8afAv3Rlwd1WIYhueOkL6C8uk4 NwZpeewtcp5bInyUOxbfXLoIu.SfTnm1z90B5jnAFovJLZNbRmoeQDMDyu8EFSCMPK3O1AjM7qrr YtJyun86IgaEhdlQfKIUxMyfBNMLawJMIiQRxItOyQjQKAxGhz.jtTjKR8ws5rUIidskbtvUzGIH iD.j5R7svwP0YqvZPrP8ZA4eq04TJNKWrb.F6NINKZNH8snaHDpb3Mnxz3HHwyaSQvPFoigNewat s6s5q_BtizietLGRmQa.Z0daqKd8akoJMraU7MbnWIWmv5GXvTvvFy4jslQUzJqQaEJMyGPgif0U X5xRvrbxvihDQbHL39qBVScVkd7q2NX00ePIbO20mw X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.bf2.yahoo.com with HTTP; Sat, 19 Mar 2022 20:43:41 +0000 Original-Received: by kubenode510.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID ecef493a475298e5ab832fe3711cc963; Sat, 19 Mar 2022 20:43:36 +0000 (UTC) In-Reply-To: <86v8w9u55t.fsf@mail.linkov.net> X-Mailer: WebService/1.1.19894 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Received-SPF: pass client-ip=74.6.129.42; envelope-from=spacibba@aol.com; helo=sonic301-3.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287309 Archived-At: ------T2DTOT6CHSOSCWLNBNQHZVCEOXDMLW Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable For a general case I am not sure this is correct or desired because the sam= e window may change buffer=2E And we want the highlight mode to be buffer = local not window local right?=2E=2E=2E Even the new function in the predisp= lay hook is buffer local=2E=2E=2E I will find confusing such a mix=2E=2E=2E Any way I am not the best lisper to have a strong opinion on this=2E But I= MHO the code is actually pretty simple to deserve a more complex approach= =2E On March 19, 2022 8:03:34 PM GMT+01:00, Juri Linkov wr= ote: >> Eli just fixed the real issue in the display engine=2E So now your code >> does not need to force the update=2E BUT it still needs to set the >> >> (setq-local cursor-face-highlight-nonselected-window t) >> >> in completion-setup-function=2E=2E=2E I can do it for you unless you pr= efer to >> add your own function to completion-setup-hook=2E > >Maybe better to set a new window parameter in the command that navigates >completions from the minibuffer=2E Then such a window parameter could be >checked in redisplay--update-cursor-face-highlight=2E > --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E ------T2DTOT6CHSOSCWLNBNQHZVCEOXDMLW Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable For a general case I am not sure this is correct o= r desired because the same window may change buffer=2E And we want the hig= hlight mode to be buffer local not window local right?=2E=2E=2E Even the ne= w function in the predisplay hook is buffer local=2E=2E=2E I will find conf= using such a mix=2E=2E=2E

Any way I am not the best lisper to have a= strong opinion on this=2E But IMHO the code is actually pretty simple to d= eserve a more complex approach=2E




On March 19, 2022 8:03:34 PM GMT+01:00, Juri Linkov <juri@linkov=2E= net> wrote:
 Eli just fixed the real issue in the display engine=2E So now yo=
ur code
 does not need to force the update=2E BUT it still needs to set =
the

 (setq-local cursor-face-highlight-nonselected-window t)

=
 in completion-setup-function=2E=2E=2E I can do it for you unless you prefe=
r to
 add your own function to completion-setup-hook=2E
=

Maybe better to set a new window parameter in the command that navigate=
s
completions from the minibuffer=2E  Then such a window parameter could=
 be
checked in redisplay--update-cursor-face-highlight=2E

<= /blockquote>
--
Sent from my Android device with K-9 Mail=2E Please excu= se my brevity=2E
------T2DTOT6CHSOSCWLNBNQHZVCEOXDMLW--