`vc-revert' keybinding

`vc-revert' keybinding

[Manuel Giraud via Emacs development discussions.]

Hi,

Maybe it was already discussed, but I wonder why the default shortcut
for `vc-revert' is 'C-x v u': this prevents from having 'u' as a
shortcut in a VC Directory mode because it is already used for
unmarking.

Why not make it 'C-x v k' ("kill" these modifications) by default and
use 'k' as shortcut in VC Directory mode?  Or maybe, keep 'C-x v u' and
add 'C-x v k' and 'k' in VC Directory mode?
-- 
Manuel Giraud

Re: `vc-revert' keybinding

[Alfred M. Szmidt]

   Hi,

   Maybe it was already discussed, but I wonder why the default shortcut
   for `vc-revert' is 'C-x v u': this prevents from having 'u' as a
   shortcut in a VC Directory mode because it is already used for
   unmarking.

C-x u is undo, C-x v u makes a logical choice for "revert" (or undo
the file to the state it is in VC).  Why is 'u' prevented from being
"unmark" in vc dir?  "Works for me"?

   Why not make it 'C-x v k' ("kill" these modifications) by default and
   use 'k' as shortcut in VC Directory mode?  Or maybe, keep 'C-x v u' and
   add 'C-x v k' and 'k' in VC Directory mode?

Kill would put something onto a kill ring, which would mean that one
should be able to "redo" something -- how that would work in VC is an
interesting question.  Does it kill the commit?  C-x v u reverts the
current file to whatever is in the repository (so .. undo?).

Re: `vc-revert' keybinding

[Manuel Giraud via Emacs development discussions.]

"Alfred M. Szmidt" <ams@gnu.org> writes:

[...]

> C-x u is undo, C-x v u makes a logical choice for "revert" (or undo
> the file to the state it is in VC).

Yes that make sense, of course.

> Why is 'u' prevented from being "unmark" in vc dir?  "Works for me"?

I haven't made myself clear.  As 'u' is already used for "unmark", it
cannot be used as a VC dir shortcut for 'C-x v u' (vc-revert) without
causing much confusion to the user.

That is why I thought that we could have another character for this that
would be the same for the 'C-x v' form, i.e.:

      - C-x v <somechar>  (globally)
      - <somechar>        (in VC dir mode)

One can always use 'C-x v u' for both, but it seems strange that emacs
does not have a VC dir shortcut for such a basic task.

>    Why not make it 'C-x v k' ("kill" these modifications) by default and
>    use 'k' as shortcut in VC Directory mode?  Or maybe, keep 'C-x v u' and
>    add 'C-x v k' and 'k' in VC Directory mode?
>
> Kill would put something onto a kill ring, which would mean that one
> should be able to "redo" something -- how that would work in VC is an
> interesting question.  Does it kill the commit?  C-x v u reverts the
> current file to whatever is in the repository (so .. undo?).

Yes, you're right.
-- 
Manuel Giraud

Re: `vc-revert' keybinding

[Alfred M. Szmidt]

   > Why is 'u' prevented from being "unmark" in vc dir?  "Works for me"?

   I haven't made myself clear.  As 'u' is already used for "unmark", it
   cannot be used as a VC dir shortcut for 'C-x v u' (vc-revert) without
   causing much confusion to the user.

   That is why I thought that we could have another character for this that
   would be the same for the 'C-x v' form, i.e.:

	 - C-x v <somechar>  (globally)
	 - <somechar>        (in VC dir mode)

   One can always use 'C-x v u' for both, but it seems strange that emacs
   does not have a VC dir shortcut for such a basic task.

It is becasue VC dired is a dired, and dired has different purpose in
general.

(What would be nice is dired supported C-x v keybindings though
... and we could get rid of vc-dired :-)

Re: `vc-revert' keybinding

[Juri Linkov]

> (What would be nice is dired supported C-x v keybindings though
> ... and we could get rid of vc-dired :-)

Dired already supports C-x v keybindings.
Still we can't get rid of vc-dired, because
it helps to see a list of modified files
compactly - that Dired can't do.

Re: `vc-revert' keybinding

[Alfred M. Szmidt]

   > (What would be nice is dired supported C-x v keybindings though
   > ... and we could get rid of vc-dired :-)

   Dired already supports C-x v keybindings.

I .. did not know that ...  thank you!

   Still we can't get rid of vc-dired, because
   it helps to see a list of modified files
   compactly - that Dired can't do.

There is nothing that really stops Dired from doing that though, it
could show it in the fringe or some otherway.

Re: `vc-revert' keybinding

[Sebastián Monía]

"Alfred M. Szmidt" <ams@gnu.org> writes:
>    Still we can't get rid of vc-dired, because
>    it helps to see a list of modified files
>    compactly - that Dired can't do.
>
> There is nothing that really stops Dired from doing that though, it
> could show it in the fringe or some otherway.

It will be harder to read, and adding *even more* features to Dired
probably isn't ideal.

I really like vc-dir, why are you trying to take it away from me :)

Cheers,
Seb

-- 
Sebastián Monía
https://site.sebasmonia.com/

Re: `vc-revert' keybinding

[Alfred M. Szmidt]

   >    Still we can't get rid of vc-dired, because
   >    it helps to see a list of modified files
   >    compactly - that Dired can't do.
   >
   > There is nothing that really stops Dired from doing that though, it
   > could show it in the fringe or some otherway.

   It will be harder to read, and adding *even more* features to Dired
   probably isn't ideal.

Not if done right.

   I really like vc-dir, why are you trying to take it away from me :)

Mostly cause dired has more features than vc-dired that are useful to
use on version controlled files. :-)

Re: `vc-revert' keybinding

[Manuel Giraud via Emacs development discussions.]

"Alfred M. Szmidt" <ams@gnu.org> writes:

>    > (What would be nice is dired supported C-x v keybindings though
>    > ... and we could get rid of vc-dired :-)
>
>    Dired already supports C-x v keybindings.
>
> I .. did not know that ...  thank you!
>
>    Still we can't get rid of vc-dired, because
>    it helps to see a list of modified files
>    compactly - that Dired can't do.
>
> There is nothing that really stops Dired from doing that though, it
> could show it in the fringe or some otherway.

Interesting idea.  But I also understand Sebastián Monía that it would
be harder to read: in VC dir, whenever I have some unregistered (and not
yet ignored) files this feels like noise to me.
-- 
Manuel Giraud

Re: `vc-revert' keybinding

[chad]

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

On Tue, Nov 5, 2024 at 3:57 AM Alfred M. Szmidt <ams@gnu.org> wrote:

>  [...]
> It is becasue VC dired is a dired, and dired has different purpose in
> general.
>
> (What would be nice is dired supported C-x v keybindings though
> ... and we could get rid of vc-dired :-)
>

What is it you're looking for that doesn't already exist? Is it just
built-in integration, or something deeper?

Apologies in advance if this is obvious; since I switched professions away
from programming, I ended up with very low frequent VC use. I have been
noodling on emacs interfaces lately, and your message caught my eye.

Thanks in advance,
~Chad

[-- Attachment #2: Type: text/html, Size: 1056 bytes --]

Re: `vc-revert' keybinding

[Sean Whitton]

Hello,

I agree it's not an ideal default binding, but I think this is something
that it is too late to change.

-- 
Sean Whitton

Re: `vc-revert' keybinding

[Sebastián Monía]

Manuel Giraud via "Emacs development discussions." <emacs-devel@gnu.org>
writes:
> Hi,
>
> Maybe it was already discussed, but I wonder why the default shortcut
> for `vc-revert' is 'C-x v u': this prevents from having 'u' as a
> shortcut in a VC Directory mode because it is already used for
> unmarking.
>
> Why not make it 'C-x v k' ("kill" these modifications) by default and
> use 'k' as shortcut in VC Directory mode?  Or maybe, keep 'C-x v u' and
> add 'C-x v k' and 'k' in VC Directory mode?

Curiously, I added "k" to revert in both vc-dir-mode-map and
vc-prefix-map in my configuration.
I was trying to remember why, I _think_ it is because that's the key
used for reverting in Magit.

I do agree with the next reply that "kill" means something completely
different in the Emacs context. That said, vc-prefix-map uses "g" for
vc-annotate, so there's precedent that not all bindings are mnemonic :)

-- 
Sebastián Monía
https://site.sebasmonia.com/

Re: `vc-revert' keybinding

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Maybe it was already discussed, but I wonder why the default shortcut
  > for `vc-revert' is 'C-x v u': this prevents from having 'u' as a
  > shortcut in a VC Directory mode because it is already used for
  > unmarking.

ISTR that vc-dir was developed some years after the original vc package
that operated on individual files' buffers.

-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)