From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make ispell localwords safe local variable Date: Wed, 16 Aug 2023 22:00:44 -0400 Message-ID: References: <87zg2s97x0.fsf@breatheoutbreathe.in> <83o7j8a59k.fsf@gnu.org> <87h6ozdalc.fsf@breatheoutbreathe.in> Reply-To: rms@gnu.org Content-Type: text/plain; charset=Utf-8 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10533"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eliz@gnu.org, emacs-devel@gnu.org To: Joseph Turner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 17 04:01:51 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWSKc-0002WX-Hn for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Aug 2023 04:01:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWSJd-00013q-QV; Wed, 16 Aug 2023 22:00:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWSJZ-00013J-BH for emacs-devel@gnu.org; Wed, 16 Aug 2023 22:00:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWSJY-0004MT-Q3; Wed, 16 Aug 2023 22:00:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From: mime-version; bh=xatsyPmK7nwS3n4lviZqzoQzSPC3wCirouha/BfKAXo=; b=EGdw3N0pjnJK idWape/TrLQ7imzee4cf3Qok2MsW/S0ZdLkmm41ZAMuymG8fGmczvFyKh/SG/U3u3QEDke+oVDT7t KGA3BeTc84QelWcTLapsVS80WFQRuJV5+QN64Lbp1ZlHIAglX3+NsAoMDcXro13dKTTW/Bycnfpt9 3NhofmnfVdxmniLVxnfIym8VrjZDktRob5nRN2Iyt/3GlGdCBXRIY0AinOAcJhfXX2TwQ7Lv1XCH0 YH3YU01eHIVlPiAZSxgr5lwTSNsjakes3RhoEVBHgsmU2pQZICFIP16Yn1X8SX5JrU1Zo9e32R+MO 6L5x+1FAToGCgnC/aGyiuA==; Original-Received: from rms by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1qWSJY-0006R6-CH; Wed, 16 Aug 2023 22:00:44 -0400 In-Reply-To: <87h6ozdalc.fsf@breatheoutbreathe.in> (message from Joseph Turner on Tue, 15 Aug 2023 18:41:18 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308841 Archived-At: [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > >> In this PR , we made it > >> possible for checkdoc/ispell to ignore localwords stored in a > >> .dir-locals.el when run in batch mode. > > I'm not sure this is indeed safe enough. We send these words to the > > spell-checker; are we sure this couldn't be abused by malicious people > > to perform some destructive actions? > I am not sure. Unless someone can be certain that ispell can safely > handle arbitrary strings, I think it's prudent to discard this patch. Suppose it doesn't handle arbitrary strings -- what's the worst that could happen? Ispell would crash perhaps? I think it would be ok to give users a chance to try using this and see Another idea: scan the localwords for "reasonableness", perhaps if in each word all the characters fit into certain classes of reasonable characters for wrds. -- Dr Richard Stallman (https://stallman.org) Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org)