Re: master 5fec9182db: Add new variable 'inhibit-native-compilation'

Re: master 5fec9182db: Add new variable 'inhibit-native-compilation'

[Andrea Corallo]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> branch: master
> commit 5fec9182dbeffa88cef6651d8c798ef9665d6681
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Add new variable 'inhibit-native-compilation'

This change introduces a variable (renamed shortly after
`inhibit-automatic-native-compilation'), but this variable fails to
actually inibhit automatic native compilation.

>     
>     * doc/lispref/compile.texi (Native-Compilation Variables):
>     Document it.
>     
>     * lisp/startup.el (normal-top-level): Set
>     inhibit-native-compilation from environment variable.

I strongly believe the use of an environment variable here should be
avoided and I don't see the necessity for it.

>     * lisp/subr.el (native-comp-deferred-compilation): Make obsolete.
>     
>     * lisp/emacs-lisp/comp.el (comp-trampoline-compile): Don't write
>     trampolines to disk.

See below.

>     * lisp/progmodes/elisp-mode.el
>     (emacs-lisp-native-compile-and-load): Adjust.
>     
>     * src/comp.c (syms_of_comp): New variable
>     inhibit-native-compilation.
>     (maybe_defer_native_compilation): Use it.
> ---

[...]

> +While setting this variable disables automatic compilation of Lisp
> +files, the compiler may still be invoked to install @dfn{trampolines}
> +if any built-in functions are redefined.  However, these trampolines
> +will not get written to disk.

This is not correct, they are actually written to disk and then removed.
Also why a variable called `inhibit-automatic-native-compilation' should
do this has still to be determined.

This change does not implement what the name suggests, does not solve
any user specific issue and was not agreed nor discussed.

As (still) native compiler maintainer I ask to have it reverted now.

Thanks

  Andrea

Re: master 5fec9182db: Add new variable 'inhibit-native-compilation'

[Lars Ingebrigtsen]

Andrea Corallo <akrl@sdf.org> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> branch: master
>> commit 5fec9182dbeffa88cef6651d8c798ef9665d6681
>> Author: Lars Ingebrigtsen <larsi@gnus.org>
>> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>>
>>     Add new variable 'inhibit-native-compilation'
>
> This change introduces a variable (renamed shortly after

Was this email stuck in your outbox for a day?  It seems like a total
non-sequitur otherwise -- you're just repeating stuff you've already
said in other threads.

Re: master 5fec9182db: Add new variable 'inhibit-native-compilation'

[Andrea Corallo]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Andrea Corallo <akrl@sdf.org> writes:
>
>> Lars Ingebrigtsen <larsi@gnus.org> writes:
>>
>>> branch: master
>>> commit 5fec9182dbeffa88cef6651d8c798ef9665d6681
>>> Author: Lars Ingebrigtsen <larsi@gnus.org>
>>> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>>>
>>>     Add new variable 'inhibit-native-compilation'
>>
>> This change introduces a variable (renamed shortly after
>
> Was this email stuck in your outbox for a day?

No I wrote it now

> It seems like a total
> non-sequitur otherwise

Maybe to you not to me

> -- you're just repeating stuff you've already
> said in other threads.

I don't think so, my mail points out more inconsistencies in this change
plus this is the right thread to ask for revertion.

If you want me to do my job, this is the only way I can do it (pointing
out things I think are not correct).  If you want me to stop doing it
just please let me know, there's no drama here trust me, I pay my bills
with other activities.

Best Regards

  Andrea

Re: master 5fec9182db: Add new variable 'inhibit-native-compilation'

[Eli Zaretskii]

> From: Andrea Corallo <akrl@sdf.org>
> Cc: emacs-devel@gnu.org
> Date: Thu, 06 Oct 2022 01:00:46 +0000
> 
> If you want me to do my job, this is the only way I can do it (pointing
> out things I think are not correct).  If you want me to stop doing it
> just please let me know, there's no drama here trust me, I pay my bills
> with other activities.

FTR, Andrea: we are very grateful to you for doing this job, and for
being there for any problems/issues reported about native compilation.
We hope very much you will keep doing this.  TIA.

Re: master 5fec9182db: Add new variable 'inhibit-native-compilation'

[tomas]

[-- Attachment #1: Type: text/plain, Size: 739 bytes --]

On Thu, Oct 06, 2022 at 09:43:37AM +0300, Eli Zaretskii wrote:
> > From: Andrea Corallo <akrl@sdf.org>
> > Cc: emacs-devel@gnu.org
> > Date: Thu, 06 Oct 2022 01:00:46 +0000
> > 
> > If you want me to do my job, this is the only way I can do it (pointing
> > out things I think are not correct).  If you want me to stop doing it
> > just please let me know, there's no drama here trust me, I pay my bills
> > with other activities.
> 
> FTR, Andrea: we are very grateful to you for doing this job, and for
> being there for any problems/issues reported about native compilation.
> We hope very much you will keep doing this.  TIA.

No question about that. Same goes to you, Eli, and to Lars et al.

Cheers & thanks
-- 
t

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: master 5fec9182db: Add new variable 'inhibit-native-compilation'

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

Please forgive us for being rude.  You're trying to help us, and even
though I for one don't work on that area of things, I appreciate it.

-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)