From: "Alfred M. Szmidt" <ams@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 55310@debbugs.gnu.org
Subject: bug#55310: 27.2; vc-revert: unhelpful error message when modified buffers exist
Date: Sun, 08 May 2022 10:22:58 -0400 [thread overview]
Message-ID: <E1nnhoI-0007PC-RC@fencepost.gnu.org> (raw)
In-Reply-To: <87y1zcjljm.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 08 May 2022 13:44:45 +0200)
"Alfred M. Szmidt" <ams@gnu.org> writes:
> When doing vc-revert in a vc-dir buffer, and when one has a bunch of
> open files, one somtimes gets the unhelpful message:
>
> vc-revert: Please kill or save all modified buffers before reverting
>
> Nicer would be prompting the user to kill/save those buffers, or list them.
I don't think we want to have an interface that offers to kill buffers
in a loop -- it sounds like something that's really error-prone, which
is why that code is the way it is, I think. (To make the user make the
decision themselves explicitly.)
We already support such mechanism I think in several other places,
like ibuffer, etc.
My main problem is really that it is impossible to know _which_
buffers are modified, if you have several hundred open in several
different projects -- in addition to the fact that the error message
is just wrong ("all buffers" -- it is just some buffers, that are
marked).
Idea (ideas are cheap): maybe if one could add some sort of
high-light, or something in vc-dired that shows that this or that file
has a open buffer that is unmodified, and then the error could be the
same but just saying that one should check the highlighted buffers.
So I think leaving it the way it is is the best option here, since this
command is one of the most potentially destructive ones we have in
Emacs. Anybody have an opinion here?
The destructiveness of vc-revert also depends on the version control
system, fossil provides a undo mechanism. But doing delete on files
in dired is far worse ... :-)
next prev parent reply other threads:[~2022-05-08 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 7:41 bug#55310: 27.2; vc-revert: unhelpful error message when modified buffers exist Alfred M. Szmidt
2022-05-08 11:44 ` Lars Ingebrigtsen
2022-05-08 14:22 ` Alfred M. Szmidt [this message]
2022-05-09 9:38 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1nnhoI-0007PC-RC@fencepost.gnu.org \
--to=ams@gnu.org \
--cc=55310@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.