From: "Francesco Potortì" <pot@potorti.it>
To: Robert Pluim <rpluim@gmail.com>
Cc: 54210@debbugs.gnu.org
Subject: bug#54210: 27.1; appt-add checks for bad data only at end
Date: Tue, 01 Mar 2022 15:31:32 +0100 [thread overview]
Message-ID: <E1nP3XI-00GeXp-Qw@tucano.isti.cnr.it> (raw)
In-Reply-To: <87v8wxiwhm.fsf@gmail.com> (rpluim@gmail.com)
>>>>>> On Tue, 01 Mar 2022 13:54:47 +0100, Francesco Potortì <pot@potorti.it> said:
> Francesco> appt-add asks the user for three parameters:
> Francesco> - time (a time string)
> Francesco> - message (a string)
> Francesco> - minutes (a number)
>
> Francesco> if the time string is badly formatted (for example if it is "8" rather
> Francesco> than "8.00") appt-add barfs. That's ok, but it barfs only after all
> Francesco> three parameters have been read. It should barf immediately after
> Francesco> submitting the wrong parameter.
>
> Francesco> Maybe I'll find the time to look at it and propose a patch, but since
> Francesco> I don't know, I prefer reporting it now.
>
>Aha, a learning opportunity (for me :-) )
>
>How about this (I canʼt find a `read-time-of-day', unless org has one hidden
>away somewhere):
>
>diff --git a/lisp/calendar/appt.el b/lisp/calendar/appt.el
>index ebdafb438e..6a3ea7c356 100644
>--- a/lisp/calendar/appt.el
>+++ b/lisp/calendar/appt.el
>@@ -510,10 +510,12 @@ appt-add
> Optional argument WARNTIME is an integer (or string) giving the number
> of minutes before the appointment at which to start warning.
> The default is `appt-message-warning-time'."
>- (interactive "sTime (hh:mm[am/pm]): \nsMessage: \n\
>-sMinutes before the appointment to start warning: ")
>- (unless (string-match appt-time-regexp time)
>- (user-error "Unacceptable time-string"))
>+ (interactive (list (let ((time (read-string "Time (hh:mm[am/pm]): ")))
>+ (unless (string-match appt-time-regexp time)
>+ (user-error "Unacceptable time-string"))
>+ time)
>+ (read-string "Message: ")
>+ (read-string "Minutes before the appointment to start warning: ")))
> (and (stringp warntime)
> (setq warntime (unless (string-equal warntime "")
> (string-to-number warntime))))
>
It works for me!
next prev parent reply other threads:[~2022-03-01 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 12:54 bug#54210: 27.1; appt-add checks for bad data only at end Francesco Potortì
2022-03-01 14:21 ` Robert Pluim
2022-03-01 14:31 ` Francesco Potortì [this message]
2022-03-01 14:40 ` Robert Pluim
2022-04-05 16:11 ` Robert Pluim
2022-03-03 23:59 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1nP3XI-00GeXp-Qw@tucano.isti.cnr.it \
--to=pot@potorti.it \
--cc=54210@debbugs.gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.