From: Richard Stallman <rms@gnu.org>
To: emacs-devel@gnu.org
Subject: Please install this and ack
Date: Sat, 26 Oct 2019 22:02:57 -0400 [thread overview]
Message-ID: <E1iOXtR-0000br-QV@fencepost.gnu.org> (raw)
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
Would someone please install this for me?
diff --git a/doc/lispref/functions.texi b/doc/lispref/functions.texi
index d082225..fe1dfa5 100644
--- a/doc/lispref/functions.texi
+++ b/doc/lispref/functions.texi
@@ -1811,9 +1811,15 @@ Advising Named Functions
(@pxref{Hooks}). If you simply want to change what a particular key
does, it may be better to write a new command, and remap the old
command's key bindings to the new one (@pxref{Remapping Commands}).
-In particular, Emacs's own source files should not put advice on
-functions in Emacs. (There are currently a few exceptions to this
-convention, but we aim to correct them.)
+
+ If you are writing code for release, for others to use, try to avoid
+including advice in it. If the function you want to advise has no
+hook to do the job, please talk with the Emacs developers about adding
+a suitable hook. Especially, Emacs's own source files should not put
+advice on functions in Emacs. (There are currently a few exceptions
+to this convention, but we aim to correct them.) It is generally
+cleaner to create a new hook in @code{foo}, and make @code{bar} use
+the hook, than to have @code{bar} put advice in @code{foo}.
Special forms (@pxref{Special Forms}) cannot be advised, however macros can
be advised, in much the same way as functions. Of course, this will not affect
--
Dr Richard Stallman
Founder, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
next reply other threads:[~2019-10-27 2:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 2:02 Richard Stallman [this message]
2019-11-01 9:47 ` Please install this and ack Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1iOXtR-0000br-QV@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.