From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison Date: Mon, 15 Apr 2019 14:14:48 -0400 Message-ID: References: <1554071761.31929.0@yandex.ru> <20190407021331.948-1-Hi-Angel@yandex.ru> <1555310948.24928.2@yandex.ru> Reply-To: rms@gnu.org Content-Type: text/plain; charset=Utf-8 Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="124724"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 15 20:16:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hG69O-000WKc-M2 for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 20:16:14 +0200 Original-Received: from localhost ([127.0.0.1]:54047 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG69N-0003GZ-K0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 14:16:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG69H-0003GH-Fc for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 14:16:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hG69F-0001w2-DH for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 14:16:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50070) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hG69C-0001uN-98 for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 14:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hG69C-0008N2-1Y for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 14:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Stallman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Apr 2019 18:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155535210232086 (code B ref 35062); Mon, 15 Apr 2019 18:16:01 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 15 Apr 2019 18:15:02 +0000 Original-Received: from localhost ([127.0.0.1]:35381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hG68D-0008Kr-0X for submit@debbugs.gnu.org; Mon, 15 Apr 2019 14:15:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37023) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hG68A-0008Kb-S6 for 35062@debbugs.gnu.org; Mon, 15 Apr 2019 14:14:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:32934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG685-0001KF-1I; Mon, 15 Apr 2019 14:14:53 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1hG680-0002jB-SR; Mon, 15 Apr 2019 14:14:49 -0400 In-Reply-To: <1555310948.24928.2@yandex.ru> (message from Konstantin Kharlamov on Mon, 15 Apr 2019 09:49:08 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157674 Archived-At: [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > IMO in such situations (i.e. when original changes were commited > without any modification anyway) would be nice to commit the original > patch, and then add up further improvements as 2-nd commit. That seems ok to me. -- Dr Richard Stallman President, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org)