Re: emacs-26 6ddb4bd: Fix 'vc-git--program-version'

Re: emacs-26 6ddb4bd: Fix 'vc-git--program-version'

[Glenn Morris]

Eli Zaretskii wrote:

> commit 6ddb4bd39ac0629e4e06221a41120aee7c18f548

>     * lisp/vc/vc-git.el (vc-git--program-version): Fix the function to
>     work with Git for Windows.
> -                       (string-match "git version \\([0-9.]+\\)$"
> -                                     version-string))
> +                       ;; Git for Windows appends ".windows.N" to the
> +                       ;; numerical version reported by Git.
> +                       (string-match
> +                        "git version \\([0-9.]+\\)\\(\.windows.[0-9]+\\)$"
> +                        version-string))

Surely this breaks on all non-MS Windows platforms?

Re: emacs-26 6ddb4bd: Fix 'vc-git--program-version'

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 16 Feb 2018 11:56:05 -0500
> 
> >     * lisp/vc/vc-git.el (vc-git--program-version): Fix the function to
> >     work with Git for Windows.
> > -                       (string-match "git version \\([0-9.]+\\)$"
> > -                                     version-string))
> > +                       ;; Git for Windows appends ".windows.N" to the
> > +                       ;; numerical version reported by Git.
> > +                       (string-match
> > +                        "git version \\([0-9.]+\\)\\(\.windows.[0-9]+\\)$"
> > +                        version-string))
> 
> Surely this breaks on all non-MS Windows platforms?

Given how much time it was "broken" on Windows without anyone
noticing, isn't it just fair that we leave it "broken" on non-Windows
platforms for approximately the same time?

Re: emacs-26 6ddb4bd: Fix 'vc-git--program-version'

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Given how much time it was "broken" on Windows without anyone
  > noticing, isn't it just fair that we leave it "broken" on non-Windows
  > platforms for approximately the same time?

Our highest priority platform is GNU, including GNU/Linux.  "It runs
best on GNU" is our motto.  We welcome code and corrections for
Windows, but we must not break anything on GNU.

-- 
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
Skype: No way! See https://stallman.org/skype.html.