From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: git history tracking across renames (and emacs support) (Was: The name gnus-cloud.el) Date: Mon, 08 Jan 2018 21:55:11 -0500 Message-ID: References: <87bmj6dda0.fsf@linux-m68k.org> <87vahe911g.fsf@lifelogs.com> <87374id7jy.fsf@linux-m68k.org> <877ett8g7k.fsf@lifelogs.com> <87a7yn7tqp.fsf@lifelogs.com> <878te75xa1.fsf@lifelogs.com> <87ind6l2tt.fsf@lifelogs.com> <877etklvsa.fsf@lifelogs.com> <83y3m0pv8u.fsf@gnu.org> <86608msw0h.fsf@dod.no> <838tdiet25.fsf@gnu.org> <87y3li4vh7.fsf@telefonica.net> <87efnan46u.fsf@linux-m68k.org> <86wp12qtgo.fsf@dod.no> <83tvw6chqv.fsf@gnu.org> <86shbprix7.fsf_-_@dod.no> <7c7503b4-1f82-8a25-fedd-c61c3e7629f6@cs.ucla.edu> <83zi5o6w4p.fsf@gnu.org> <745d2f02-8ca3-8962-0de4-053340c8fa63@cs.ucla.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: blaine.gmane.org Content-Type: text/plain; charset=Utf-8 X-Trace: blaine.gmane.org 1515466482 11620 195.159.176.226 (9 Jan 2018 02:54:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 9 Jan 2018 02:54:42 +0000 (UTC) Cc: eliz@gnu.org, sb@dod.no, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 09 03:54:38 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYk3Z-0002CC-5h for ged-emacs-devel@m.gmane.org; Tue, 09 Jan 2018 03:54:29 +0100 Original-Received: from localhost ([::1]:48604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYk5Y-0004EA-Dq for ged-emacs-devel@m.gmane.org; Mon, 08 Jan 2018 21:56:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYk4Y-0004CV-JT for emacs-devel@gnu.org; Mon, 08 Jan 2018 21:55:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYk4X-0006us-9H for emacs-devel@gnu.org; Mon, 08 Jan 2018 21:55:30 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYk4F-0006g2-Rv; Mon, 08 Jan 2018 21:55:11 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eYk4F-000159-Ag; Mon, 08 Jan 2018 21:55:11 -0500 In-reply-to: <745d2f02-8ca3-8962-0de4-053340c8fa63@cs.ucla.edu> (message from Paul Eggert on Mon, 8 Jan 2018 10:41:34 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221741 Archived-At: [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > If it's important enough to > mention the change from extern to static in the commit message, the > current guidelines would seem to imply that it's important enough to > mention why the change was made in code comments. Here's what the standard actually says: If you think that a change calls for explanation, you're probably right. Please do explain it---but please put the full explanation in comments in the code, where people will see it whenever they see the code. So you're criticizing a practice which is NOT our standard. Note also that it talks about "explanation". We recommend such comments, NOT to state the facts of what changed, but to explain the reasons for the change _when that seems useful to explain_. Our advice does NOT suggest adding a comment to state the fact that the variable was changed to static. However, if the reason for this change was not evident, it would be good to explain that reason in comments. -- Dr Richard Stallman President, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) Skype: No way! See https://stallman.org/skype.html.