From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Francesco =?UTF-8?Q?Potort=C3=AC?= Newsgroups: gmane.emacs.bugs Subject: bug#29659: 25.2; better rmail-summary-by-topic Date: Mon, 11 Dec 2017 16:50:14 +0100 Message-ID: References: <83zi6ps2fv.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Trace: blaine.gmane.org 1513007476 5642 195.159.176.226 (11 Dec 2017 15:51:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 11 Dec 2017 15:51:16 +0000 (UTC) Cc: 29659@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 11 16:51:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOQMJ-0001Fk-6z for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Dec 2017 16:51:11 +0100 Original-Received: from localhost ([::1]:54148 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOQMQ-00023U-Cy for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Dec 2017 10:51:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOQMG-00022O-1x for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2017 10:51:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOQMB-0007D0-3K for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2017 10:51:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48330) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOQMA-0007Ck-Vh for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2017 10:51:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eOQMA-0002Yy-OG for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2017 10:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Francesco =?UTF-8?Q?Potort=C3=AC?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2017 15:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29659 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29659-submit@debbugs.gnu.org id=B29659.15130074239738 (code B ref 29659); Mon, 11 Dec 2017 15:51:02 +0000 Original-Received: (at 29659) by debbugs.gnu.org; 11 Dec 2017 15:50:23 +0000 Original-Received: from localhost ([127.0.0.1]:57001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOQLX-0002X0-DR for submit@debbugs.gnu.org; Mon, 11 Dec 2017 10:50:23 -0500 Original-Received: from mx1.isti.cnr.it ([194.119.192.3]:7284 helo=blade3.isti.cnr.it) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOQLU-0002Wl-Co for 29659@debbugs.gnu.org; Mon, 11 Dec 2017 10:50:20 -0500 Original-Received: from savesent-daemon.mx-all.isti.cnr.it by mx-all.isti.cnr.it (PMDF V6.7-x04 #1609) id <01QMIY55TXG0C526DF@mx-all.isti.cnr.it> for 29659@debbugs.gnu.org; Mon, 11 Dec 2017 16:50:15 +0100 (MET) Original-Received: from tucano.isti.cnr.it ([146.48.81.102]) by mx-all.isti.cnr.it (PMDF V6.7-x04 #1609) with ESMTPSA id <01QMIY55BXASCA2YX7@mx-all.isti.cnr.it>; Mon, 11 Dec 2017 16:50:14 +0100 (MET) Original-Received: from pot by tucano.isti.cnr.it with local (Exim 4.90_RC3) (envelope-from ) id 1eOQLO-0002xh-GD; Mon, 11 Dec 2017 16:50:14 +0100 In-reply-to: <83zi6ps2fv.fsf@gnu.org> X-INSM-ip-source: 146.48.81.102 Auth Done X-fingerprint: 4B02 6187 5C03 D6B1 2E31 7666 09DF 2DC9 BE21 6115 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140932 Archived-At: >> Date: Mon, 11 Dec 2017 13:28:12 +0100 >> From: Francesco Potort́ >> >> rmail-summary-by-topic functionality can be easily improved by this >> piece of advice: >> >> (defun rmail-simplified-subject--strip-all (subject) >> "Strip all prefixes like Re:, Fwd: and similar ones" >> (let ((search-spaces-regexp "[ \t\n]")) >> (string-match " *\\(\\(\\w\\{1,3\\}:\\|\\[.+]\\) +\\)*" subject) >> (replace-match "" t t subject)) >> ) >> (advice-add 'rmail-simplified-subject :filter-return #'rmail-simplified-subject--strip-all) >> >> >> Maybe this can be simply incorporated into rmail-simplified-subject: it >> is able to remove prefixes like >> >> Re: [Topic] Fwd: Re: Fwd: >> >> and in practice I find it very useful >Indeed, and so I wonder why did you need the advice? Which prefixes >does rmail-simplified-subject not handle correctly? It is much more primitive, it only removes a single Re: prefix. This means that repeated prefixes and localised prefixes are left as they are, as you can see: (defun rmail-simplified-subject (&optional msgnum) "Return the simplified subject of message MSGNUM (or current message). Simplifying the subject means stripping leading and trailing whitespace, and typical reply prefixes such as Re:." (let ((subject (or (rmail-get-header "Subject" msgnum) ""))) (setq subject (rfc2047-decode-string subject)) (if (string-match "\\`[ \t]+" subject) (setq subject (substring subject (match-end 0)))) (if (string-match rmail-reply-regexp subject) (setq subject (substring subject (match-end 0)))) (if (string-match "[ \t]+\\'" subject) (setq subject (substring subject 0 (match-beginning 0)))) ;; If Subject is long, mailers will break it into several lines at ;; arbitrary places, so normalize whitespace by replacing every ;; run of whitespace characters with a single space. (setq subject (replace-regexp-in-string "[ \t\n]+" " " subject)) subject))