From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: Why does make run git? Date: Tue, 01 Aug 2017 10:30:36 -0400 Message-ID: References: <83bmo00yw7.fsf@gnu.org> Reply-To: rms@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1501597865 17281 195.159.176.226 (1 Aug 2017 14:31:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 1 Aug 2017 14:31:05 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 01 16:31:00 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcYCF-00042s-Vt for ged-emacs-devel@m.gmane.org; Tue, 01 Aug 2017 16:30:56 +0200 Original-Received: from localhost ([::1]:42920 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcYCL-0002SB-RX for ged-emacs-devel@m.gmane.org; Tue, 01 Aug 2017 10:31:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcYC2-0002Lc-3f for emacs-devel@gnu.org; Tue, 01 Aug 2017 10:30:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcYBx-00027n-5i for emacs-devel@gnu.org; Tue, 01 Aug 2017 10:30:42 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcYBx-00027U-3Q for emacs-devel@gnu.org; Tue, 01 Aug 2017 10:30:37 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dcYBw-0004TB-Dz; Tue, 01 Aug 2017 10:30:36 -0400 In-reply-to: <83bmo00yw7.fsf@gnu.org> (message from Eli Zaretskii on Tue, 01 Aug 2017 06:07:04 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217203 Archived-At: [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > > git config transfer.fsckObjects 'true' > This makes Git abort if it sees a bad object being pulled or pushed. Isn't that a personal preference? It seems wrong for Emacs to set it arbitrarily. > > git config diff.elisp.xfuncname '^\(def[^[:space:]]+[[:space:]]+([^()[:space:]]+)' > > git config diff.m4.xfuncname '^((m4_)?define|A._DEFUN(_ONCE)?)\([^),]*' > > git config diff.make.xfuncname '^([$.[:alnum:]_].*:|[[:alnum:]_]+[[:space:]]*([*:+]?[:?]?|!?)=|define .*)' > > git config diff.shell.xfuncname '^([[:space:]]*[[:alpha:]_][[:alnum:]_]*[[:space:]]*\(\)|[[:alpha:]_][[:alnum:]_]*=)' > > git config diff.texinfo.xfuncname '^@node[[:space:]]+([^,[:space:]][^,]+)' > These tailor the Git's notion of a "function" for the various > languages. It's handy in several commands that need to know where a > function begins and ends. Do you mean, several Git commands, or several Emacs commands? I would guess it is the former. Running make on the Emacs checkout seems like an inadequate place to do this. There is no assurance that you will run make in that checkout before committing anything. Perhaps there should be a function in Emacs that does this, and some VC commands could call it. > > Installing git hooks... > > ‘build-aux/git-hooks/commit-msg’ -> ‘.git/hooks/commit-msg’ > > ‘build-aux/git-hooks/pre-commit’ -> ‘.git/hooks/pre-commit’ > > ‘.git/hooks/applypatch-msg.sample’ -> ‘.git/hooks/applypatch-msg’ > > ‘.git/hooks/pre-applypatch.sample’ -> ‘.git/hooks/pre-applypatch’ > These hooks check the format of the commits and verify it is > according to our standards. Running make on Emacs seems like an unreliable place to do this, because there is no assurance that you will run make in that checkout before committing anything. -- Dr Richard Stallman President, Free Software Foundation (gnu.org, fsf.org) Internet Hall-of-Famer (internethalloffame.org) Skype: No way! See stallman.org/skype.html.