"unescaped character literals detected"

"unescaped character literals detected"

[Eli Zaretskii]

Compiling the Lisp files in the current master produces quite a few of
these new warnings, see below.  I hope someone is looking into
eliminating them, otherwise we introduced a safety feature that does
nothing except annoying us.

Also, there seem to be several instances of the same warning, only one
of which points out the line number where the problem happens.  Is it
possible to output only that final warning?  The rest of them, those
without a line number, are useless, as there's no practical way of
finding the offending code unless you know exactly what to look for
(and the wording isn't specific enough to allow the latter).

Thanks.

  60 matches for "unescaped" in buffer: build-log
     1002:Loading `skeleton': unescaped character literals (, ), [, ] detected!
     1058:Loading `skeleton': unescaped character literals (, ), [, ] detected!
     1109:Loading `cperl-mode': unescaped character literals (, ), [, ] detected!
     1205:skeleton.el:490:1:Warning: unescaped character literals (, ), [, ] detected!
     1247:woman.el:4404:1:Warning: unescaped character literals [, ] detected!
     1387:calendar/timeclock.el:640:1:Warning: unescaped character literals [, ]
     3436:emulation/viper-cmd.el:91:1:Warning: unescaped character literals (, ), [, ]
     3450:Loading `viper-cmd': unescaped character literals (, ), [, ] detected!
     3626:Loading `ob-ref': unescaped character literals (, ) detected!
     3883:language/japan-util.el:100:1:Warning: unescaped character literals [, ]
     3915:leim/quail/cyrillic.el:181:1:Warning: unescaped character literals (, )
     3917:leim/quail/cyrillic.el:737:1:Warning: unescaped character literals (, )
     4070:mh-e/mh-search.el:1504:1:Warning: unescaped character literals (, ) detected!
     4167:Loading `xsd-regexp': unescaped character literals (, ), [, ] detected!
     4169:Loading `xsd-regexp': unescaped character literals (, ), [, ] detected!
     4219:Loading `xsd-regexp': unescaped character literals (, ), [, ] detected!
     4224:nxml/xsd-regexp.el:621:1:Warning: unescaped character   ELC      obsolete/cc-com
     4241:obsolete/complete.el:436:1:Warning: unescaped character literals [, ]
     4299:obsolete/vi.el:1437:1:Warning: unescaped character literals (, ), [, ]
     4315:Loading `ob-ref': unescaped character literals (, ) detected!
     4317:Loading `ob-ref': unescaped character literals (, ) detected!
     4318:Loading `ob-ref': unescaped character literals (, ) detected!
     4319:Loading `obL-ref': unescaped cohaadriancg `toebr-r elfi't:e runaeslcsap ed( ,ch
     4322:Loading `ob-ref': unescaped   ELC      org/ob-core.elcch
     4331:Loading `ob-ref': unescaped character literals (, ) detected!
     4332:Loading `ob-ref': unescaped character literals (, ) detected!
     4333:Loading `ob-ref': unescaped character literals (, ) detected!
     4335:Loading `ob-ref': unescaped character literals (, ) detected!
     4341:Loading `ob-ref': unescaped character literals (, ) detected!
     4342:Loading `ob-ref': unescaped character literals (, ) detected!
     4343:Loading `ob-ref': unescaped character literals (, ) detected!
     4344:Loading `ob-ref': unescaped character literals (, ) detected!
     4345:Loading `ob-ref': unescaped character literals (, ) detected!
     4350:Loading `ob-ref': unescaped character literals (, ) detected!
     4353:Loading `ob-ref': unescaped character literals (, ) detected!
     4354:Loading `ob-ref': unescaped character literals (, ) detected!
     4355:Loading `ob-ref': unescaped character literals (, ) detected!
     4356:Loading `ob-ref': unescaped character literals (, ) detected!
     4365:Loading `ob-ref': unescaped character literals (, ) detected!
     4368:Loading `ob-ref': unescaped character literals (, ) detected!
     4370:oading `ob-ref': unescaped character literals (, ) detected!
     4372:Loading `ob-ref': unescaped character literals (, ) detected!
     4375:Loading `ob-ref': unescaped character literals (, ) detected!
     4377:Loading `ob-ref': unescaped character literals (, ) detected!
     4380:Loading `ob-ref': unescaped character literals (, ) detected!
     4381:Loading `ob-ref': unescaped character literals (, ) detected!
     4384:org/ob-ref.el:126:1:Warning: unescaped chaLracotaedri nlgi t`eorba-lrse f(',:  )
     4703:Loading `ada-mode': unescaped character literals (, ) detected!
     4704:Loading `ada-mode': unescaped character literals (, ) detected!
     4708:-mode.el:1651:1:Warning: unescaped character literals (, )
     4710:Loading `ada-mode': unescaped character literals (, ) detected!
     4725:progmodes/cperl-mode.el:2146:1:Warning: unescaped character literals (, ), [,
     4750:Loading `gud': unescaped character literals (, ), [, ] detected!
     4761:progmodes/gud.el:3097:1:Warning: unescaped character literals (, ), [, ]
     4777:progmodes/idlw-shell.el:4145:1:Warning: unescaped character literals [, ]
     4808:progmodes/sh-script.el:602:1:Warning: unescaped character literals (, ), [, ]
     4815:progmodes/tcl.el:1524:1:Warning: unescaped character literals [, ] detected!
     4843:progmodes/verilog-mode.el:14003:1:Warning: unescaped character literals ;
     4845:progmodes/verilog-mode.el:14013:1:Warning: unescaped character literals ;
     4847:progmodes/verilog-mode.el:14205:1:Warning: unescaped character literals ;

Re: "unescaped character literals detected"

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

On Thu, May 4, 2017 at 10:39 AM Eli Zaretskii <eliz@gnu.org> wrote:

> Compiling the Lisp files in the current master produces quite a few of
> these new warnings, see below.  I hope someone is looking into
> eliminating them, otherwise we introduced a safety feature that does
> nothing except annoying us.
>
> Also, there seem to be several instances of the same warning, only one
> of which points out the line number where the problem happens.  Is it
> possible to output only that final warning?  The rest of them, those
> without a line number, are useless, as there's no practical way of
> finding the offending code unless you know exactly what to look for
> (and the wording isn't specific enough to allow the latter).
>

+1

Now when I load verilog-mode.el (autoloaded when I open the SystemVerilog
files), I get:

Loading ‘verilog-mode’: unescaped character literals ; detected!

verilog-mode.el has 14.5k lines. It would be very helpful to print the line
number where unescapted character literals are detected so that I can
attempt to fix it.

Thanks.

PS: This was added in
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c2bbdc3316487e34eba1470dd059c0c290431e00,
so copying Philipp.
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1840 bytes --]

Help fix unescaped character literals detected warnings in verilog-mode (Was: Re: "unescaped character literals detected")

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 2801 bytes --]

On Fri, May 5, 2017 at 3:49 PM Kaushal Modi <kaushal.modi@gmail.com> wrote:

> verilog-mode.el has 14.5k lines. It would be very helpful to print the
> line number where unescapted character literals are detected so that I can
> attempt to fix it.
>

A quick followup:

I byte-compiled verilog-mode.el, and it throws these warnings:

verilog-mode.el:14003:1:Warning: unescaped character literals ; detected!
verilog-mode.el:14013:1:Warning: unescaped character literals ; detected!
verilog-mode.el:14205:1:Warning: unescaped character literals ; detected!

I believe that the compiler does not like lines like

> "task " '(verilog-sk-prompt-name) & ?; \n

Changing that to the below fixes the warning:

> "task " '(verilog-sk-prompt-name) & \?; \n


But I am not familiar with the define-skeleton syntax. Does anyone know if
changing "?" to "\?" in the below 3 instances of skeleton definitions would
be fine?

On line 14003, there is:

(define-skeleton verilog-sk-task
  "Insert a task definition."
  ()
  > "task " '(verilog-sk-prompt-name) & ?; \n
  > _ \n
  > "begin" \n
  > \n
  > (- verilog-indent-level-behavioral) "end" \n
  > (- verilog-indent-level-behavioral) "endtask" (progn
(electric-verilog-terminate-line) nil))

On line 14013, there is:

(define-skeleton verilog-sk-function
  "Insert a function definition."
  ()
  > "function [" '(verilog-sk-prompt-width) | -1 '(verilog-sk-prompt-name)
?; \n
  > _ \n
  > "begin" \n
  > \n
  > (- verilog-indent-level-behavioral) "end" \n
  > (- verilog-indent-level-behavioral) "endfunction" (progn
(electric-verilog-terminate-line) nil))

On line 14205, there is:

(define-skeleton verilog-sk-state-machine
  "Insert a state machine definition."
  "Name of state variable: "
  '(setq input "state")
  > "// State registers for " str | -23 \n
  '(setq verilog-sk-state str)
  > "reg [" '(verilog-sk-prompt-width) | -1 verilog-sk-state ", next_"
verilog-sk-state ?; \n
  '(setq input nil)
  > \n
  > "// State FF for " verilog-sk-state \n
  > "always @ ( " (read-string "clock:" "posedge clk") " or "
(verilog-sk-prompt-reset) " ) begin" \n
  > "if ( " verilog-sk-reset " ) " verilog-sk-state " = 0; else" \n
  > verilog-sk-state " = next_" verilog-sk-state ?; \n
  > (- verilog-indent-level-behavioral) "end" (progn
(electric-verilog-terminate-line) nil)
  > \n
  > "// Next State Logic for " verilog-sk-state \n
  > "always @ ( /*AUTOSENSE*/ ) begin\n"
  > "case (" '(verilog-sk-prompt-state-selector) ") " \n
  > ("case selector: " str ": begin" \n > "next_" verilog-sk-state " = " _
";" \n > (- verilog-indent-level-behavioral) "end" \n )
  resume: >  (- verilog-case-indent) "endcase" (progn
(electric-verilog-terminate-line) nil)
  > (- verilog-indent-level-behavioral) "end" (progn
(electric-verilog-terminate-line) nil))

-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 4683 bytes --]

Re: Help fix unescaped character literals detected warnings in verilog-mode (Was: Re: "unescaped character literals detected")

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 3794 bytes --]

Kaushal Modi <kaushal.modi@gmail.com> schrieb am Fr., 5. Mai 2017, 22:00:

> On Fri, May 5, 2017 at 3:49 PM Kaushal Modi <kaushal.modi@gmail.com>
> wrote:
>
>> verilog-mode.el has 14.5k lines. It would be very helpful to print the
>> line number where unescapted character literals are detected so that I can
>> attempt to fix it.
>>
>
> A quick followup:
>
> I byte-compiled verilog-mode.el, and it throws these warnings:
>
> verilog-mode.el:14003:1:Warning: unescaped character literals ; detected!
> verilog-mode.el:14013:1:Warning: unescaped character literals ; detected!
> verilog-mode.el:14205:1:Warning: unescaped character literals ; detected!
>
> I believe that the compiler does not like lines like
>
> > "task " '(verilog-sk-prompt-name) & ?; \n
>
> Changing that to the below fixes the warning:
>
> > "task " '(verilog-sk-prompt-name) & \?; \n
>
>
> But I am not familiar with the define-skeleton syntax. Does anyone know if
> changing "?" to "\?" in the below 3 instances of skeleton definitions would
> be fine?
>

You should change it to ?\;
I.e. escape the ; not the ?


> On line 14003, there is:
>
> (define-skeleton verilog-sk-task
>   "Insert a task definition."
>   ()
>   > "task " '(verilog-sk-prompt-name) & ?; \n
>   > _ \n
>   > "begin" \n
>   > \n
>   > (- verilog-indent-level-behavioral) "end" \n
>   > (- verilog-indent-level-behavioral) "endtask" (progn
> (electric-verilog-terminate-line) nil))
>
> On line 14013, there is:
>
> (define-skeleton verilog-sk-function
>   "Insert a function definition."
>   ()
>   > "function [" '(verilog-sk-prompt-width) | -1 '(verilog-sk-prompt-name)
> ?; \n
>   > _ \n
>   > "begin" \n
>   > \n
>   > (- verilog-indent-level-behavioral) "end" \n
>   > (- verilog-indent-level-behavioral) "endfunction" (progn
> (electric-verilog-terminate-line) nil))
>
> On line 14205, there is:
>
> (define-skeleton verilog-sk-state-machine
>   "Insert a state machine definition."
>   "Name of state variable: "
>   '(setq input "state")
>   > "// State registers for " str | -23 \n
>   '(setq verilog-sk-state str)
>   > "reg [" '(verilog-sk-prompt-width) | -1 verilog-sk-state ", next_"
> verilog-sk-state ?; \n
>   '(setq input nil)
>   > \n
>   > "// State FF for " verilog-sk-state \n
>   > "always @ ( " (read-string "clock:" "posedge clk") " or "
> (verilog-sk-prompt-reset) " ) begin" \n
>   > "if ( " verilog-sk-reset " ) " verilog-sk-state " = 0; else" \n
>   > verilog-sk-state " = next_" verilog-sk-state ?; \n
>   > (- verilog-indent-level-behavioral) "end" (progn
> (electric-verilog-terminate-line) nil)
>   > \n
>   > "// Next State Logic for " verilog-sk-state \n
>   > "always @ ( /*AUTOSENSE*/ ) begin\n"
>   > "case (" '(verilog-sk-prompt-state-selector) ") " \n
>   > ("case selector: " str ": begin" \n > "next_" verilog-sk-state " = " _
> ";" \n > (- verilog-indent-level-behavioral) "end" \n )
>   resume: >  (- verilog-case-indent) "endcase" (progn
> (electric-verilog-terminate-line) nil)
>   > (- verilog-indent-level-behavioral) "end" (progn
> (electric-verilog-terminate-line) nil))
>
> --
>
> Kaushal Modi
>
-- 

Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank.

This e-mail is confidential. If you are not the right addressee please do
not forward it, please inform the sender, and please erase this e-mail
including any attachments. Thanks.

[-- Attachment #2: Type: text/html, Size: 6114 bytes --]

Re: "unescaped character literals detected"

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 2090 bytes --]

Kaushal Modi <kaushal.modi@gmail.com> schrieb am Fr., 5. Mai 2017, 21:49:

> On Thu, May 4, 2017 at 10:39 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
>> Compiling the Lisp files in the current master produces quite a few of
>> these new warnings, see below.  I hope someone is looking into
>> eliminating them, otherwise we introduced a safety feature that does
>> nothing except annoying us.
>>
>> Also, there seem to be several instances of the same warning, only one
>> of which points out the line number where the problem happens.  Is it
>> possible to output only that final warning?  The rest of them, those
>> without a line number, are useless, as there's no practical way of
>> finding the offending code unless you know exactly what to look for
>> (and the wording isn't specific enough to allow the latter).
>>
>
> +1
>
> Now when I load verilog-mode.el (autoloaded when I open the SystemVerilog
> files), I get:
>
> Loading ‘verilog-mode’: unescaped character literals ; detected!
>
> verilog-mode.el has 14.5k lines. It would be very helpful to print the
> line number where unescapted character literals are detected so that I can
> attempt to fix it.
>
> Thanks.
>
> PS: This was added in
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c2bbdc3316487e34eba1470dd059c0c290431e00,
> so copying Philipp.
>


Yes, I'll fix all those over the weekend. Generally you can mechanically
replace ?( with ?\( etc.

Kaushal Modi
>
-- 

Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank.

This e-mail is confidential. If you are not the right addressee please do
not forward it, please inform the sender, and please erase this e-mail
including any attachments. Thanks.

[-- Attachment #2: Type: text/html, Size: 3216 bytes --]

Re: Help fix unescaped character literals detected warnings in verilog-mode (Was: Re: "unescaped character literals detected")

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

On Fri, May 5, 2017 at 4:02 PM Philipp Stephani <phst@google.com> wrote:

>
> You should change it to ?\;
> I.e. escape the ; not the ?
>

 Thanks for the explanation. As I understand, you will be fixing all of
these?
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 608 bytes --]

Re: Help fix unescaped character literals detected warnings in verilog-mode

[Stefan Monnier]

> verilog-mode.el:14003:1:Warning: unescaped character literals ; detected!

Now that I see it, the error message should say ?; rather than ;
since some people may not immediately know what is a character literal
in this context.


        Stefan

Re: Help fix unescaped character literals detected warnings in verilog-mode (Was: Re: "unescaped character literals detected")

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

Kaushal Modi <kaushal.modi@gmail.com> schrieb am Fr., 5. Mai 2017 um
22:14 Uhr:

> On Fri, May 5, 2017 at 4:02 PM Philipp Stephani <phst@google.com> wrote:
>
>>
>> You should change it to ?\;
>> I.e. escape the ; not the ?
>>
>
>  Thanks for the explanation. As I understand, you will be fixing all of
> these?
>
>
Yes, the ones that are in the Emacs repo.
-- 

Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank.

This e-mail is confidential. If you are not the right addressee please do
not forward it, please inform the sender, and please erase this e-mail
including any attachments. Thanks.

[-- Attachment #2: Type: text/html, Size: 1813 bytes --]

Re: Help fix unescaped character literals detected warnings in verilog-mode

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > > verilog-mode.el:14003:1:Warning: unescaped character literals ; detected!

  > Now that I see it, the error message should say ?; rather than ;
  > since some people may not immediately know what is a character literal
  > in this context.

Our convention for messages that mention some text
is to put `...' around that text.

-- 
Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.

Re: Help fix unescaped character literals detected warnings in verilog-mode (Was: Re: "unescaped character literals detected")

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

Philipp Stephani <phst@google.com> schrieb am Fr., 5. Mai 2017 um 23:35 Uhr:

> Kaushal Modi <kaushal.modi@gmail.com> schrieb am Fr., 5. Mai 2017 um
> 22:14 Uhr:
>
>> On Fri, May 5, 2017 at 4:02 PM Philipp Stephani <phst@google.com> wrote:
>>
>>>
>>> You should change it to ?\;
>>> I.e. escape the ; not the ?
>>>
>>
>>  Thanks for the explanation. As I understand, you will be fixing all of
>> these?
>>
>>
> Yes, the ones that are in the Emacs repo.
>
>
These should now be fixed with 3c4c8ca06e3306ccbcd07e354eb51abe53b52d22.

[-- Attachment #2: Type: text/html, Size: 1643 bytes --]

Re: Help fix unescaped character literals detected warnings in verilog-mode (Was: Re: "unescaped character literals detected")

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

On Sun, May 7, 2017, 8:37 AM Philipp Stephani

These should now be fixed with 3c4c8ca06e3306ccbcd07e354eb51abe53b52d22.
>

Thanks!

> --

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 726 bytes --]

Re: Help fix unescaped character literals detected warnings in verilog-mode (Was: Re: "unescaped character literals detected")

[Eli Zaretskii]

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 07 May 2017 12:36:54 +0000
> 
> Philipp Stephani <phst@google.com> schrieb am Fr., 5. Mai 2017 um 23:35 Uhr:
> 
>  Kaushal Modi <kaushal.modi@gmail.com> schrieb am Fr., 5. Mai 2017 um 22:14 Uhr:
> 
>  On Fri, May 5, 2017 at 4:02 PM Philipp Stephani <phst@google.com> wrote:
> 
>  You should change it to ?\;
>  I.e. escape the ; not the ?
> 
>  Thanks for the explanation. As I understand, you will be fixing all of these?
> 
>  Yes, the ones that are in the Emacs repo. 
> 
> These should now be fixed with 3c4c8ca06e3306ccbcd07e354eb51abe53b52d22. 

Thanks.

Re: Help fix unescaped character literals detected warnings in verilog-mode

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 704 bytes --]

Richard Stallman <rms@gnu.org> schrieb am So., 7. Mai 2017 um 00:44 Uhr:

> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
> [[[ whether defending the US Constitution against all enemies,     ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>
>   > > verilog-mode.el:14003:1:Warning: unescaped character literals ;
> detected!
>
>   > Now that I see it, the error message should say ?; rather than ;
>   > since some people may not immediately know what is a character literal
>   > in this context.
>
> Our convention for messages that mention some text
> is to put `...' around that text.
>

OK, I've installed commit 16004397f4 to fix the messages.

[-- Attachment #2: Type: text/html, Size: 1053 bytes --]