From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Rafael D Sorkin Newsgroups: gmane.emacs.bugs Subject: bug#24270: Seeming bug in `setf' Date: Sun, 21 Aug 2016 20:34:47 -0400 Message-ID: References: Reply-To: Rafael D Sorkin NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1471826121 23872 195.159.176.226 (22 Aug 2016 00:35:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 22 Aug 2016 00:35:21 +0000 (UTC) Cc: 24270-done@debbugs.gnu.org To: Michael Heerdegen , Nicolas Petton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 22 02:35:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbdCu-0005sH-6V for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Aug 2016 02:35:16 +0200 Original-Received: from localhost ([::1]:38970 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbdCr-0008Ci-43 for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Aug 2016 20:35:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbdCk-0008Ad-LO for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 20:35:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbdCg-0007ZU-Fc for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 20:35:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbdCg-0007ZQ-9V for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 20:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bbdCg-0005X7-2O for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 20:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Rafael D Sorkin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Aug 2016 00:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24270 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24270-done@debbugs.gnu.org id=D24270.147182609521251 (code D ref 24270); Mon, 22 Aug 2016 00:35:02 +0000 Original-Received: (at 24270-done) by debbugs.gnu.org; 22 Aug 2016 00:34:55 +0000 Original-Received: from localhost ([127.0.0.1]:36304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbdCZ-0005Wh-Cd for submit@debbugs.gnu.org; Sun, 21 Aug 2016 20:34:55 -0400 Original-Received: from mail-qt0-f226.google.com ([209.85.216.226]:36661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbdCX-0005WV-QV for 24270-done@debbugs.gnu.org; Sun, 21 Aug 2016 20:34:54 -0400 Original-Received: by mail-qt0-f226.google.com with SMTP id u25so5527331qtb.3 for <24270-done@debbugs.gnu.org>; Sun, 21 Aug 2016 17:34:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perimeterinstitute-ca.20150623.gappssmtp.com; s=20150623; h=reply-to:from:to:cc:subject:in-reply-to:message-id:date; bh=xsfzfHX5zvFUXWP3lqcIl2Kb9LEkqpeOg2euBgiaGmA=; b=VSvWfIUQLKpDqXy7rNrHjJ266fhra6RzIAVmqVCfSsEzMOYChIE4C7Gok2qzTSkF9n TQZ5ElPbJ0XNPO9tUTNViWIsOVTgvLe1Y/Qiq6ckisKSeC1TFfJjcXUEL2kvVEA4BnCO BGhyqCcg2e1GT7vs88xvdvt3+W9eJ6/yMX3oX+OPJV/qyqQzogBpoX68KMWy+Btj6O3A zrv/oFcILSG16vGspcwjsoThxSRhYzEEvnUvAZpSKdJzP5n3MRsA69mxpcY4AzCs6z5A pwwEsrCnZAHzgs8Bz9S3CAup1G2wSzRIzLoKXbEW3JU+XbJrtXYysUbjzELRVocm54Ed 1pbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:reply-to:from:to:cc:subject:in-reply-to :message-id:date; bh=xsfzfHX5zvFUXWP3lqcIl2Kb9LEkqpeOg2euBgiaGmA=; b=HEllkqZiHVUXnyKKOBUgiHamKVxiFibADuyk8N8CjmGgshszyc6bE8fO3BYXiH4ZjA vA/eBfp/J3w5puQa+QhOemcQhI/cqfiwwhGE5jcy/n2oQv1Yhd33Cn2jWNBVq7nHahCK uZ0zF8fP8DVjAGBhjGEfkaDaRrpKjRj5zsjVBCkrdZK3Xf42cZR1gk8Q/XpVf8Re8fgS 7MpLikOO+JGG0flyxv7JNc0kkZcnwVeXpFOcTPXiMofqaq7V8tvPSFR+UMpTBbIe39DH /BJF3Axuiz/MZUZjo0w2VoD546EL0i2zQB5/Amp0UNqQOLzFzcE44S9WNnsvzvYuKfED 16lA== X-Gm-Message-State: AEkoouu286FhFcmQgY4yNYHU2HD22ZMRw3pVCNGB+HKGkhlvdugDkfK/PRxKshxqo+j2SnZyWbU6c7KTVhoqVYcAJsotUOJn X-Received: by 10.36.207.8 with SMTP id y8mr18088128itf.63.1471826088311; Sun, 21 Aug 2016 17:34:48 -0700 (PDT) Original-Received: from mail.perimeterinstitute.ca (nat.perimeterinstitute.ca. [38.117.109.20]) by smtp-relay.gmail.com with ESMTP id p123sm2438909itg.1.2016.08.21.17.34.47; Sun, 21 Aug 2016 17:34:48 -0700 (PDT) X-Relaying-Domain: perimeterinstitute.ca Original-Received: from mars.pi.local (mars.pi.local [10.10.7.6]) by mail.perimeterinstitute.ca (Postfix) with ESMTPS id 33190C09A9; Sun, 21 Aug 2016 20:38:23 -0400 (EDT) Original-Received: from rsorkin by mars.pi.local with local (Exim 4.69) (envelope-from ) id 1bbdCR-000874-Mk; Sun, 21 Aug 2016 20:34:47 -0400 X-Mailer: MH-E 8.2; nmh 1.2; GNU Emacs 23.1.1 In-reply-to: your message of Sat, 20 Aug 2016 16:03:34 +0200 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122479 Archived-At: Hello Michael and Nico, The maintainer here says that emacs 25 is not yet officially released. He has asked me to ask you which version has the bug fixed: "Please inquire which version has the error corrected; we can then install them. If this requires installing a non-relased version, this will be fine as well, but we then won't make it the default setting for new users." Is there a released version in which the bug has been fixed? Can you advise me which version would be best for him to install? Many thanks, Rafael > Hello Rafael, > > > (emacs-version) ; GNU Emacs 24.3.1 (x86_64-pc-linux-gnu, GTK+ Version > > 3.10.7) of 2014-03-07 on lamiak, modified by Debian > > > > (setq z ()) > > (getf z 'indic) ; nil > > (setf (getf z 'indic) 6) ; (indic 6) SHOULD BE JUST 6 > > (getf z 'indic) ; 6 okay > > Thanks for reporting. Yes, there was such a bug, but your Emacs version > is very old...and the bug has been fixed in the meantime (three years > ago) in > > > c46c57b, Stefan Monnier > > * lisp/emacs-lisp/cl-extra.el (cl-getf): Return the proper value in > the setter. > > Fixes: debbugs:14387 > > > modified lisp/emacs-lisp/cl-extra.el > @@ -597,8 +597,11 @@ cl-getf > (macroexp-let2 nil d def > (funcall do `(cl-getf ,getter ,k ,d) > (lambda (v) > - (funcall setter > - `(cl--set-getf ,getter ,k ,v)))))))))) > + (macroexp-let2 nil val v > + `(progn > + ,(funcall setter > + `(cl--set-getf ,getter ,k ,val)) > + ,val)))))))))) > (setplist '--cl-getf-symbol-- plist) > (or (get '--cl-getf-symbol-- tag) > ;; Originally we called cl-get here, > modified lisp/emacs-lisp/cl-loaddefs.el > > > Regards, > > Michael. > Hi Rafael, > > Thank you for reporting this issue. > > > The macro `setf' seems to have developed a bug somewhere between emacs 23.1.1 and 24.3.1: > > > > (emacs-version) ; GNU Emacs 24.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.10.7) of 2014-03-07 on lamiak, modified by Debian > > > > (setq z ()) > > (getf z 'indic) ; nil > > (setf (getf z 'indic) 6) ; (indic 6) SHOULD BE JUST 6 > > (getf z 'indic) ; 6 okay > > It seems to have been fixed in master & Emacs 25.1 RC1, so I'm closing the > issue. > > However, if you can still reproduce it in master (I couldn't, but who > knows), feel free to reopen it. > > Cheers, > Nico ~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~- Rafael Sorkin Perimeter Institute for Theoretical Physics 31 Caroline Street North Waterloo, ON N2L 2Y5 Canada ~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~- A story-poem by Mark Twain -- http://warprayer.org/ ~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-