Re: [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.

Re: [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.

[Stefan Monnier]

>     * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.

One more time: please always include some kind of explanation when you
revert code.  E.g. a bug# or something.


        Stefan

Re: [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

FWIW I actually liked the indent change that was put in the first place. If
you look at the explanation in that commit, it makes sense why that indent
change was done.

I did not understand why it was reverted in this recent commit.

Kaushal

On Saturday, February 27, 2016, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> >     * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent
> change.
>
> One more time: please always include some kind of explanation when you
> revert code.  E.g. a bug# or something.
>
>
>         Stefan
>
>

-- 

--
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 892 bytes --]

Re: [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.

[Leo Liu]

On 2016-02-27 10:02 -0500, Kaushal Modi wrote:
> FWIW I actually liked the indent change that was put in the first place. If
> you look at the explanation in that commit, it makes sense why that indent
> change was done.

Sorry I can't check the explanation now since I lost connection to my
server which hosts the emacs repo. Could you post the explanation?

> I did not understand why it was reverted in this recent commit.
>
> Kaushal

Could you show me a code example that has bad indentation that (indent
3) fixes? Adding (indent 3) gives bad indentation to some previously
well-indented code. The previous indentation setting seems more
flexible.

Leo

Re: [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > >     * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.

  > One more time: please always include some kind of explanation when you
  > revert code.  E.g. a bug# or something.

Even in this sort of case, I think the best place for the explanation
is in the source file, where the reverted code was.

-- 
Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.

Re: [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.

[Stefan Monnier]

> Even in this sort of case, I think the best place for the explanation
> is in the source file, where the reverted code was.

Agreed.  But as a first step "somewhere" is better than "nowhere".


        Stefan