From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.bugs Subject: bug#11242: 24.1.50; Switching to rmai view buffer Date: Mon, 16 Apr 2012 18:01:48 -0400 Message-ID: References: <4F89C750.9010508@gmx.at> <83aa2e15sn.fsf@gnu.org> <4F8A8351.40808@gmx.at> <87sjg4q8ta.fsf@gnu.org> Reply-To: rms@gnu.org NNTP-Posting-Host: plane.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: dough.gmane.org 1334613726 5887 80.91.229.3 (16 Apr 2012 22:02:06 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 16 Apr 2012 22:02:06 +0000 (UTC) Cc: 11242@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 17 00:02:05 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SJtzo-0001uj-G6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Apr 2012 00:02:04 +0200 Original-Received: from localhost ([::1]:48337 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SJtzn-0006NK-Qr for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Apr 2012 18:02:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SJtzl-0006N9-4P for bug-gnu-emacs@gnu.org; Mon, 16 Apr 2012 18:02:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SJtzj-0007DL-6S for bug-gnu-emacs@gnu.org; Mon, 16 Apr 2012 18:02:00 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SJtzj-0007DF-2R for bug-gnu-emacs@gnu.org; Mon, 16 Apr 2012 18:01:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SJtzm-0004TM-CW for bug-gnu-emacs@gnu.org; Mon, 16 Apr 2012 18:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Stallman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Apr 2012 22:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11242-submit@debbugs.gnu.org id=B11242.133461371817181 (code B ref 11242); Mon, 16 Apr 2012 22:02:02 +0000 Original-Received: (at 11242) by debbugs.gnu.org; 16 Apr 2012 22:01:57 +0000 Original-Received: from localhost ([127.0.0.1]:37408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SJtzg-0004T3-67 for submit@debbugs.gnu.org; Mon, 16 Apr 2012 18:01:56 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:58565 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SJtzd-0004Sw-VR for 11242@debbugs.gnu.org; Mon, 16 Apr 2012 18:01:54 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SJtzY-0005Zf-1Q; Mon, 16 Apr 2012 18:01:48 -0400 In-reply-to: <87sjg4q8ta.fsf@gnu.org> (message from Chong Yidong on Mon, 16 Apr 2012 18:18:09 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59144 Archived-At: This code is wrong; the NEWBUF should not be passed to rmail-mail-return, it should be the BUFFER variable in the loop. I've committed a fix. I think you're right. However, it is nonetheless true that other-buffer should not return buffers whose names start with space. BTW, having code in mail-bury to specially handle Rmail buffers is kinda ugly. This probably needs to be folded into the quit-window mechanism, somehow. In the first place, I'm not even sure it's appropriate to redirect the user to an Rmail buffer if the mail command was not started from Rmail. Yes it is appropriate. I put it in because the lack of it was a nuisance. But if that feature were removed, look what would happen: (if (and (null arg) return-action) (apply (car return-action) (cdr return-action)) (switch-to-buffer newbuf)))) It would switch to NEWBUF, the same bug as was just happening. -- Dr Richard Stallman President, Free Software Foundation 51 Franklin St Boston MA 02110 USA www.fsf.org www.gnu.org Skype: No way! That's nonfree (freedom-denying) software. Use Ekiga or an ordinary phone call