`mail-encode-header' encodes encoded header

`mail-encode-header' encodes encoded header

[Katsumi Yamaoka]

Hi,

2012-03-10  Richard Stallman  <rms@gnu.org>

	* mail/sendmail.el (mail-encode-header):
	Set rfc2047-encode-encoded-words.

Please don't do that.  Because:

2011-05-27  Kenichi Handa  <handa@m17n.org>

	* mail/sendmail.el (mail-encode-header): Avoid double encoding by
	let-binding rfc2047-encode-encoded-words to nil.

I use Gnus and smtpmail, that uses mail-encode-header, to send
mails.  Gnus passes a mail of which the header and the body are
fully encoded to smtpmail, so the double encoding takes place!
I often write mail's subject in Japanese, Gnus encodes it into

Subject: =?iso-2022-jp?B?GyRCJUYlOSVIGyhC?=

, and now it is encoded again into:

Subject: =?us-ascii?Q?=3D=3Fiso-2022-jp=3FB=3FGyRCJUYlOSVIGyhC=3F=3D?=

There is no mail software that decodes it into human-readable one.

Regards,

Re: `mail-encode-header' encodes encoded header

[Lars Magne Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> 2012-03-10  Richard Stallman  <rms@gnu.org>
>
> 	* mail/sendmail.el (mail-encode-header):
> 	Set rfc2047-encode-encoded-words.
>
> Please don't do that.  Because:
>
> 2011-05-27  Kenichi Handa  <handa@m17n.org>
>
> 	* mail/sendmail.el (mail-encode-header): Avoid double encoding by
> 	let-binding rfc2047-encode-encoded-words to nil.
>
> I use Gnus and smtpmail, that uses mail-encode-header, to send
> mails.  Gnus passes a mail of which the header and the body are
> fully encoded to smtpmail, so the double encoding takes place!

This patch should be reverted ASAP, because people are starting to see
corrupted email messages...

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Re: `mail-encode-header' encodes encoded header

[Katsumi Yamaoka]

Lars Magne Ingebrigtsen wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:

>> 2012-03-10  Richard Stallman  <rms@gnu.org>
>>
>> 	* mail/sendmail.el (mail-encode-header):
>> 	Set rfc2047-encode-encoded-words.
>>
>> Please don't do that.  Because:
>>
>> 2011-05-27  Kenichi Handa  <handa@m17n.org>
>>
>> 	* mail/sendmail.el (mail-encode-header): Avoid double encoding by
>> 	let-binding rfc2047-encode-encoded-words to nil.
>>
>> I use Gnus and smtpmail, that uses mail-encode-header, to send
>> mails.  Gnus passes a mail of which the header and the body are
>> fully encoded to smtpmail, so the double encoding takes place!

> This patch should be reverted ASAP, because people are starting to see
> corrupted email messages...

Fixed with a comment.  Thanks!

Re: `mail-encode-header' encodes encoded header

[Richard Stallman]

There was definitely a bug that occurred in using sendmail.el
without that change.  But I don't recall the test case and
I could not come up with one now.  So I don't object
to removing the change.  But I think the problem will show
up again.

--
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org  www.gnu.org
Skype: No way! That's nonfree (freedom-denying) software.
  Use free telephony http://directory.fsf.org/category/tel/

Re: `mail-encode-header' encodes encoded header

[Eli Zaretskii]

> Date: Wed, 14 Mar 2012 04:54:29 -0400
> From: Richard Stallman <rms@gnu.org>
> Cc: yamaoka@jpl.org, ding@gnus.org, emacs-devel@gnu.org
> 
> There was definitely a bug that occurred in using sendmail.el
> without that change.  But I don't recall the test case and
> I could not come up with one now.  So I don't object
> to removing the change.  But I think the problem will show
> up again.

When it does, please describe it.  It can never be TRT to encode an
already encoded address.  There must be some other bug in some other
place, which prevents the address from being encoded in the first
place.