From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#9983: valgrind warning in draw_glyphs Date: Mon, 07 Nov 2011 00:49:07 -0500 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1320644961 18773 80.91.229.12 (7 Nov 2011 05:49:21 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 7 Nov 2011 05:49:21 +0000 (UTC) Cc: 9983@debbugs.gnu.org To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 07 06:49:17 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RNI57-0007UZ-DE for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Nov 2011 06:49:17 +0100 Original-Received: from localhost ([::1]:38241 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNI56-0006wZ-MB for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Nov 2011 00:49:16 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:55781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNI53-0006wL-Oz for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2011 00:49:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNI52-00053K-Ih for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2011 00:49:13 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNI52-00053E-Fn for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2011 00:49:12 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RNI7m-0003G8-3x for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2011 00:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Nov 2011 05:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9983 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9983-submit@debbugs.gnu.org id=B9983.132064511812519 (code B ref 9983); Mon, 07 Nov 2011 05:52:02 +0000 Original-Received: (at 9983) by debbugs.gnu.org; 7 Nov 2011 05:51:58 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNI7i-0003Fr-A6 for submit@debbugs.gnu.org; Mon, 07 Nov 2011 00:51:58 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RNI7h-0003Fl-2A for 9983@debbugs.gnu.org; Mon, 07 Nov 2011 00:51:57 -0500 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RNI4x-0006gC-6B; Mon, 07 Nov 2011 00:49:07 -0500 In-reply-to: (message from Dan Nicolaescu on Sun, 06 Nov 2011 23:36:42 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 07 Nov 2011 00:52:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:53644 Archived-At: > From: Dan Nicolaescu > Date: Sun, 06 Nov 2011 23:36:42 -0500 > > The warning is for this: > if (check_mouse_face > && mouse_beg_col < start && mouse_end_col > i) > > it looks like mouse_beg_col and mouse_end_col could be left uninitialized a few lines above. I don't see how. These variables are initialized in this block: if (row >= mouse_beg_row && row <= mouse_end_row) { check_mouse_face = 1; mouse_beg_col = (row == mouse_beg_row) ? hlinfo->mouse_face_beg_col : 0; mouse_end_col = (row == mouse_end_row) ? hlinfo->mouse_face_end_col : row->used[TEXT_AREA]; } check_mouse_face starts as zero, and is only set to 1 in this block. So any test that is conditioned on check_mouse_face being non-zero is okay with looking at mouse_beg_col and mouse_end_col. The other variables in the line being flagged, `start' and `i', are also okay: `start' is one of the call arguments and `i' is computed right before the line being flagged. Did I miss something?