all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: Your changes in revision 106240
Date: Sun, 30 Oct 2011 02:16:31 -0400	[thread overview]
Message-ID: <E1RKOh5-0003uJ-C6@fencepost.gnu.org> (raw)
In-Reply-To: <jwvvcr7m5q7.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sun, 30 Oct 2011 01:06:16 -0400)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> Date: Sun, 30 Oct 2011 01:06:16 -0400
> 
> >> what possible harm can be done by using an int here?
> > On a typical 64-bit host, using 'int' breaks a GDB command like
> > "xwhichsymbols Qnil 4294967297", by causing xwhichsymbols
> > to silently treat the 4294967297 as if it were 1.
> 
> But this has nothing to do with EMACS_INT.  It's at best a misfeature in
> the GDB->C interfacing that doesn't warn of such rounding, tho one might
> argue that they are intentional and that a programmer should expect them.

Even if we wanted to support such ridiculously large values, TRT would
be to make that argument `long', not EMACS_INT, because we have the
"--with-wide-int" configuration where EMACS_INT is a 64-bit type
whereas GDB will pass a 32-bit value.

> In any case, this arg is *never* going to be that large.

Right.  And moreover, a GDB user who stupidly passes such a large
value will hurt no one but herself, so we don't need to protect Emacs
from that.



  parent reply	other threads:[~2011-10-30  6:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-29 20:54 Your changes in revision 106240 Eli Zaretskii
2011-10-30  2:44 ` Paul Eggert
2011-10-30  5:06   ` Stefan Monnier
2011-10-30  6:06     ` Paul Eggert
2011-10-30  6:28       ` Eli Zaretskii
2011-10-30  6:31       ` Stefan Monnier
2011-10-30  7:15         ` Paul Eggert
2011-10-30  7:27           ` Eli Zaretskii
2011-10-31  6:23             ` Paul Eggert
2011-10-30  8:07           ` Stefan Monnier
2011-10-31  6:28             ` Paul Eggert
2011-10-30  6:16     ` Eli Zaretskii [this message]
2011-10-30  7:04       ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1RKOh5-0003uJ-C6@fencepost.gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.