From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#9722: list-colors-duplicates does not exclude enough colors on Windows Date: Tue, 11 Oct 2011 02:01:33 -0400 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1318312918 23316 80.91.229.12 (11 Oct 2011 06:01:58 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 11 Oct 2011 06:01:58 +0000 (UTC) Cc: 9722@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 11 08:01:52 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RDVPU-00024j-O2 for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Oct 2011 08:01:52 +0200 Original-Received: from localhost ([::1]:41921 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDVPU-0006pb-0e for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Oct 2011 02:01:52 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:49001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDVPQ-0006nt-Ti for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2011 02:01:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RDVPP-0002oU-Uu for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2011 02:01:48 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDVPP-0002oQ-RX for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2011 02:01:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RDVPe-0003WI-F0 for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2011 02:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Oct 2011 06:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9722 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9722-submit@debbugs.gnu.org id=B9722.131831291213514 (code B ref 9722); Tue, 11 Oct 2011 06:02:02 +0000 Original-Received: (at 9722) by debbugs.gnu.org; 11 Oct 2011 06:01:52 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDVPT-0003Vu-04 for submit@debbugs.gnu.org; Tue, 11 Oct 2011 02:01:52 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDVPR-0003Vm-9H for 9722@debbugs.gnu.org; Tue, 11 Oct 2011 02:01:49 -0400 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RDVPB-0000HK-FA; Tue, 11 Oct 2011 02:01:33 -0400 In-reply-to: (message from Juanma Barranquero on Tue, 11 Oct 2011 00:49:43 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 11 Oct 2011 02:02:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:52505 Archived-At: > From: Juanma Barranquero > Date: Tue, 11 Oct 2011 00:49:43 +0200 > > On Windows, `list-colors-duplicates' matches the color name against > the output of `w32-default-color-map', to avoid conflating colors > which are RGB-equal, but semantically different, like SystemMenuText > and SystemWindowText. > > Unfortunately, that makes colors not in that list different even if > they are not, in particular all the grayNN/greyNN pairs. The duplicates annoyed me as well; thanks for taking care of it. However, there's something I'm missing here: why doesn't list-colors-duplicates recognize grayNN and greyNN as duplicates? We don't have them in the list that w32-default-color-map returns. As for duplicates such as "Dark Slate Gray" and "Dark Slate Grey", which are not filtered out because they _are_ in w32-default-color-map, would something break if we modify the list returned by that function to not include any duplicates in the first place?