From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 8657@debbugs.gnu.org
Subject: bug#8657: 24.0.50; Emacs code that seems to use `*-single-char-property-change' incorrectly
Date: Thu, 12 May 2011 00:44:33 -0400 [thread overview]
Message-ID: <E1QKNlJ-0001p9-CC@fencepost.gnu.org> (raw)
In-Reply-To: <jwvvcxg62lm.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Thu, 12 May 2011 00:05:46 -0300)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Thu, 12 May 2011 00:05:46 -0300
> Cc: 8657@debbugs.gnu.org
>
> > In particular, IIUC, the return value can never be nil.
> > Yet I see code such as this:
>
> > gnus-summary-show-thread:
> > (or (next-single-char-property-change end 'invisible) (point-max))
>
> > comint-next-prompt:
> > (setq pos (next-single-char-property-change pos 'field))
> > (cond (or (null pos)...
>
> > Isn't this incorrect?
>
> The behavior might have changed at some point in time, explaining the
> above code.
Or maybe the author was confusing next-single-char-property-change
with next-single-property-change.
In any case, those tests are redundant, because
next-single-char-property-change already returns point-max when it
finds no change in properties.
next prev parent reply other threads:[~2011-05-12 4:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 20:54 bug#8657: 24.0.50; Emacs code that seems to use `*-single-char-property-change' incorrectly Drew Adams
2011-05-12 3:05 ` Stefan Monnier
2011-05-12 4:44 ` Eli Zaretskii [this message]
2011-05-12 13:44 ` bug#8657: 24.0.50; Emacs code that seems to use `*-single-char-property-change'incorrectly Drew Adams
2012-02-06 14:00 ` bug#8657: 24.0.50; Emacs code that seems to use `*-single-char-property-change' incorrectly Chong Yidong
2012-02-06 22:56 ` Katsumi Yamaoka
2012-02-07 5:57 ` Chong Yidong
2012-02-07 6:34 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1QKNlJ-0001p9-CC@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=8657@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.