From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#8651: `raise' properties on NextStep Date: Wed, 11 May 2011 09:08:39 -0400 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1305119352 11589 80.91.229.12 (11 May 2011 13:09:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 11 May 2011 13:09:12 +0000 (UTC) Cc: 8651@debbugs.gnu.org To: Alp Aker Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 11 15:09:08 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QK9A2-00084s-NR for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 May 2011 15:09:06 +0200 Original-Received: from localhost ([::1]:42441 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QK9A2-0003La-68 for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 May 2011 09:09:06 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:32783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QK9A0-0003LR-89 for bug-gnu-emacs@gnu.org; Wed, 11 May 2011 09:09:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QK99z-0004WQ-81 for bug-gnu-emacs@gnu.org; Wed, 11 May 2011 09:09:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QK99z-0004WJ-3U for bug-gnu-emacs@gnu.org; Wed, 11 May 2011 09:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QK99y-0008JL-FG; Wed, 11 May 2011 09:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 May 2011 13:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8651 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8651-submit@debbugs.gnu.org id=B8651.130511932831927 (code B ref 8651); Wed, 11 May 2011 13:09:02 +0000 Original-Received: (at 8651) by debbugs.gnu.org; 11 May 2011 13:08:48 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QK99j-0008Iu-Ii for submit@debbugs.gnu.org; Wed, 11 May 2011 09:08:47 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QK99h-0008Ii-Iy for 8651@debbugs.gnu.org; Wed, 11 May 2011 09:08:46 -0400 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1QK99b-0007bP-7Q; Wed, 11 May 2011 09:08:39 -0400 In-reply-to: (message from Alp Aker on Tue, 10 May 2011 18:14:31 +0000 (UTC)) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 11 May 2011 09:09:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46383 Archived-At: > From: Alp Aker > Date: Tue, 10 May 2011 18:14:31 +0000 (UTC) > > Yesterday it came up on a thread on the devel list that on > NextStep the `raise' property increases line height but does > nothing more; it doesn't alter the vertical positioning of > characters. The question then arose whether this was a bug on > NextStep, since the implementation of display properties isn't > OS-specific. This is a misunderstanding. I never said that the problem is outside Emacs. I said that it's probably in the NS-specific parts of Emacs. Most of the work of handling the `raise' property is in device-independent code in xdisp.c. However, the terminal-specific code should obey the computed metrics of the glyphs when it draws the glyphs on the screen. It looks like NS-specific display code doesn't, while both xterm.c and w32term.c do, see x_draw_glyph_string_foreground. > The above change is naive, and will break other things (such as > underline positioning), but it serves as a proof of concept that > the issue is on Emacs's side. Of course, it's on the Emacs side! Where else could it possibly be? It would be silly to claim that NextStep as a system cannot draw characters at pixel resolution. > many of the > gylph-drawing functions in nsterm.m and nsfont.m only check the y field > to determine the vertical position of a glyph; they don't use ybase > at all. Which constitutes an NS-specific bug in Emacs.