From: Eli Zaretskii <eliz@gnu.org>
To: Alp Aker <aker@pitt.edu>
Cc: 8651@debbugs.gnu.org
Subject: bug#8651: `raise' properties on NextStep
Date: Wed, 11 May 2011 09:08:39 -0400 [thread overview]
Message-ID: <E1QK99b-0007bP-7Q@fencepost.gnu.org> (raw)
In-Reply-To: <loom.20110510T201126-921@post.gmane.org> (message from Alp Aker on Tue, 10 May 2011 18:14:31 +0000 (UTC))
> From: Alp Aker <aker@pitt.edu>
> Date: Tue, 10 May 2011 18:14:31 +0000 (UTC)
>
> Yesterday it came up on a thread on the devel list that on
> NextStep the `raise' property increases line height but does
> nothing more; it doesn't alter the vertical positioning of
> characters. The question then arose whether this was a bug on
> NextStep, since the implementation of display properties isn't
> OS-specific.
This is a misunderstanding. I never said that the problem is outside
Emacs. I said that it's probably in the NS-specific parts of Emacs.
Most of the work of handling the `raise' property is in
device-independent code in xdisp.c. However, the terminal-specific
code should obey the computed metrics of the glyphs when it draws the
glyphs on the screen. It looks like NS-specific display code doesn't,
while both xterm.c and w32term.c do, see
x_draw_glyph_string_foreground.
> The above change is naive, and will break other things (such as
> underline positioning), but it serves as a proof of concept that
> the issue is on Emacs's side.
Of course, it's on the Emacs side! Where else could it possibly be?
It would be silly to claim that NextStep as a system cannot draw
characters at pixel resolution.
> many of the
> gylph-drawing functions in nsterm.m and nsfont.m only check the y field
> to determine the vertical position of a glyph; they don't use ybase
> at all.
Which constitutes an NS-specific bug in Emacs.
next prev parent reply other threads:[~2011-05-11 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 18:14 bug#8651: `raise' properties on NextStep Alp Aker
2011-05-11 13:08 ` Eli Zaretskii [this message]
2011-05-11 21:55 ` Alp Aker
2011-05-11 14:44 ` Stefan Monnier
2011-06-22 18:21 ` Alp Aker
2011-06-25 13:03 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1QK99b-0007bP-7Q@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=8651@debbugs.gnu.org \
--cc=aker@pitt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.