From: Yuanle Song <sylecn@gmail.com>
To: 8516@debbugs.gnu.org
Subject: bug#8516: nxml-mode: pattern matching should be case-sensitive in validation
Date: Mon, 18 Apr 2011 05:00:16 -0500 [thread overview]
Message-ID: <E1QBlFg-00015y-RY@sylecn> (raw)
In-Reply-To: <87ipucoftf.fsf@raven.defaultvalue.org>
I think it's because string-match ignore case when case-fold-search is t
(which is the default), so greped a little on nxml dir and found the
following function may be the problem. But I haven't read the how the
whole file and don't know how nxml validation works, so some one more
knowledgeable should verify this is the right thing to do.
I tested on the test.xml and test.rnc and after this patch, capitalized
"Test" will result an invalid xml file.
Thanks,
Yuanle
--- /home/sylecn/fromsource/emacs-23.3/lisp/nxml/rng-xsd.el 2011-01-08 11:45:14.000000000 -0600
+++ /home/sylecn/fromsource/emacs/lisp/nxml/rng-xsd.el 2011-04-18 04:35:08.135816534 -0500
@@ -238,7 +238,7 @@
obj)))
(defun rng-xsd-check-pattern (str regexp convert &rest args)
- (and (string-match regexp str)
+ (and (let (case-fold-search) (string-match regexp str))
(apply convert (cons str args))))
next prev parent reply other threads:[~2011-04-18 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 19:09 bug#8516: nxml-mode: pattern matching should be case-sensitive in validation Rob Browning
2011-04-18 10:00 ` Yuanle Song [this message]
2011-05-22 19:47 ` Chong Yidong
2011-04-18 10:52 ` Lawrence Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1QBlFg-00015y-RY@sylecn \
--to=sylecn@gmail.com \
--cc=8516@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.