From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Supporting parameters that include the = character in configure.bat Date: Sun, 10 Apr 2011 05:49:25 -0400 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1302428994 10439 80.91.229.12 (10 Apr 2011 09:49:54 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 10 Apr 2011 09:49:54 +0000 (UTC) Cc: Emacs-devel@gnu.org To: Ben Key Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 10 11:49:48 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8rH7-0005R8-P6 for ged-emacs-devel@m.gmane.org; Sun, 10 Apr 2011 11:49:46 +0200 Original-Received: from localhost ([127.0.0.1]:57525 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q8rH0-0007j3-4O for ged-emacs-devel@m.gmane.org; Sun, 10 Apr 2011 05:49:38 -0400 Original-Received: from [140.186.70.92] (port=42058 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q8rGp-0007i7-NQ for Emacs-devel@gnu.org; Sun, 10 Apr 2011 05:49:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8rGo-0007Vx-DC for Emacs-devel@gnu.org; Sun, 10 Apr 2011 05:49:27 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:47111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q8rGo-0007Vs-7f for Emacs-devel@gnu.org; Sun, 10 Apr 2011 05:49:26 -0400 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Q8rGn-0004Jr-Pz; Sun, 10 Apr 2011 05:49:25 -0400 In-reply-to: (message from Ben Key on Sun, 10 Apr 2011 03:46:39 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138350 Archived-At: > From: Ben Key > Date: Sun, 10 Apr 2011 03:46:39 -0500 > Cc: Emacs-devel@gnu.org > > > This isn't a problem, because we don't support building Emacs on > > Windows 9X anyway. > > I was not aware of this. Configure.bat still has some comments that refer > to Windows 9x and command.com Yeah, we need to remove that at some point. > @echo off > set use_extensions=1 > setlocal enableextensions > if errorlevel 1 set use_extensions=0 You cannot rely on the fact that errorlevel is zero before entering the batch file. See "setlocal /?", it suggests a more reliable method. > if "%use_extensions%" == "1" goto ucflagex > goto ucflag What happens if extensions are disabled? Will arguments with "=" work? If not, we need to display a warning. Anyway, "cmd /?" seems to imply that even if the extensions are disabled in the Registry, one can enable them in an inferior shell by invoking "cmd /e:on". If that is true, perhaps if you determine that the extensions are disabled, you should reinvoke the batch file with "cmd /e:on". If this works it's better than punting.