From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Francesco =?UTF-8?Q?Potort=C3=AC?= Newsgroups: gmane.emacs.bugs Subject: bug#8093: etags: Downcase drive letters, for consistency with Emacs proper. Date: Tue, 22 Feb 2011 11:11:36 +0100 Message-ID: References: <4D6353B4.5010104@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1298383083 25527 80.91.229.12 (22 Feb 2011 13:58:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 22 Feb 2011 13:58:03 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org, owner@debbugs.gnu.org, 8093@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 22 14:57:58 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PrskE-0000Hh-Fc for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Feb 2011 14:57:55 +0100 Original-Received: from localhost ([127.0.0.1]:51322 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Prsd0-00018l-7g for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Feb 2011 08:50:10 -0500 Original-Received: from [140.186.70.92] (port=49382 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrsQ0-00032N-33 for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2011 08:36:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrsPy-00018J-Vt for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2011 08:36:43 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrsPy-00018F-Sx for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2011 08:36:42 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PrrxG-0002b9-Ki; Tue, 22 Feb 2011 08:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Francesco =?UTF-8?Q?Potort=C3=AC?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Feb 2011 13:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8093 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8093-submit@debbugs.gnu.org id=B8093.12983799809924 (code B ref 8093); Tue, 22 Feb 2011 13:07:02 +0000 Original-Received: (at 8093) by debbugs.gnu.org; 22 Feb 2011 13:06:20 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PrrwY-0002Zy-Rl for submit@debbugs.gnu.org; Tue, 22 Feb 2011 08:06:19 -0500 Original-Received: from blade3.isti.cnr.it ([194.119.192.19]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PrpEe-0006PF-Ij for 8093@debbugs.gnu.org; Tue, 22 Feb 2011 05:12:55 -0500 Original-Received: from SCRIPT-SPFWL-DAEMON.mx.isti.cnr.it by mx.isti.cnr.it (PMDF V6.5-x5 #31825) id <01NY4IFFO8R4PHYFUK@mx.isti.cnr.it> for 8093@debbugs.gnu.org; Tue, 22 Feb 2011 11:11:39 +0100 (MET) Original-Received: from conversionlocal.isti.cnr.it by mx.isti.cnr.it (PMDF V6.5-x5 #31825) id <01NY4IFFDUU8PHXZ9M@mx.isti.cnr.it> for 8093@debbugs.gnu.org; Tue, 22 Feb 2011 11:11:38 +0100 (MET) Original-Received: from tucano.isti.cnr.it (tucano.isti.cnr.it [146.48.81.102]) by mx.isti.cnr.it (PMDF V6.5-x5 #31826) with ESMTPSA id <01NY4IFE9J8YPSZSV6@mx.isti.cnr.it>; Tue, 22 Feb 2011 11:11:36 +0100 (MET) Original-Received: from pot by tucano.isti.cnr.it with local (Exim 4.72) (envelope-from ) id 1PrpDU-0002HP-QK; Tue, 22 Feb 2011 11:11:37 +0100 In-reply-to: <4D6353B4.5010104@cs.ucla.edu> X-INSM-ip-source: 146.48.81.102 Auth Done X-fingerprint: 4B02 6187 5C03 D6B1 2E31 7666 09DF 2DC9 BE21 6115 X-Mailman-Approved-At: Tue, 22 Feb 2011 08:06:16 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 22 Feb 2011 08:07:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:44298 Archived-At: >Emacs downcases drive letters when canonicalizing file names on >Microsoft Windows, but etags upcases them. etags should be consistent >with Emacs. I found this problem by code inspection, because there's >a macro 'upcase' that normally isn't used in etags.c; its only use is >in the section of code that upcases drive letters. Here's a proposed >patch. Looks reasonable and I see no compatibility issues. Please install it. >2011-02-21 Paul Eggert > > etags: Downcase drive letters, for consistency with Emacs proper. > * etags.c (upcase): Remove; no longer used. > (canonicalize_filename): Downcase drive letters. > >--- lib-src/etags.c 2011-02-21 16:47:08.883947000 -0800 >+++ /u/cs/fac/eggert/junk/etags.c 2011-02-21 21:21:04.074974000 -0800 >@@ -239,7 +239,6 @@ If you want regular expression support, > #define ISLOWER(c) islower (CHAR(c)) > > #define lowcase(c) tolower (CHAR(c)) >-#define upcase(c) toupper (CHAR(c)) > > > /* >@@ -6638,7 +6637,7 @@ filename_is_absolute (char *fn) > ); > } > >-/* Upcase DOS drive letter and collapse separators into single slashes. >+/* Downcase DOS drive letter and collapse separators into single slashes. > Works in place. */ > static void > canonicalize_filename (register char *fn) >@@ -6648,8 +6647,8 @@ canonicalize_filename (register char *fn > > #ifdef DOS_NT > /* Canonicalize drive letter case. */ >- if (fn[0] != '\0' && fn[1] == ':' && ISLOWER (fn[0])) >- fn[0] = upcase (fn[0]); >+ if (fn[0] != '\0' && fn[1] == ':' && ISUPPER (fn[0])) >+ fn[0] = downcase (fn[0]); > > sep = '\\'; > #endif > > > > > >