From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: draft patch to import gnulib's filemode module into Emacs Date: Sun, 20 Feb 2011 07:42:20 -0500 Message-ID: References: <4D60F860.6020303@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1298205759 26179 80.91.229.12 (20 Feb 2011 12:42:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 20 Feb 2011 12:42:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 20 13:42:35 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pr8cT-0005Ns-Hi for ged-emacs-devel@m.gmane.org; Sun, 20 Feb 2011 13:42:33 +0100 Original-Received: from localhost ([127.0.0.1]:59694 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pr8cT-0007j2-0V for ged-emacs-devel@m.gmane.org; Sun, 20 Feb 2011 07:42:33 -0500 Original-Received: from [140.186.70.92] (port=48363 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pr8cJ-0007hP-43 for emacs-devel@gnu.org; Sun, 20 Feb 2011 07:42:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pr8cH-0004ZL-Rx for emacs-devel@gnu.org; Sun, 20 Feb 2011 07:42:22 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:35113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pr8cH-0004ZH-MI for emacs-devel@gnu.org; Sun, 20 Feb 2011 07:42:21 -0500 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Pr8cG-0000vD-PS; Sun, 20 Feb 2011 07:42:20 -0500 In-reply-to: <4D60F860.6020303@cs.ucla.edu> (message from Paul Eggert on Sun, 20 Feb 2011 03:17:52 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136278 Archived-At: > Date: Sun, 20 Feb 2011 03:17:52 -0800 > From: Paul Eggert > > Here's a draft patch to import gnulib's filemode module > into Emacs. Thanks. > * lib/sys/stat.h is built on hosts whose has problems. > I expect that Windows does not have these problems, > so this part can be ignored. Actually, no, it cannot be ignored. The new filemode.c uses the S_*GRP and S_*OTH macros, which are not defined on Windows. (The previous version of filemode.c didn't use these macros.) And that's just at first glance, without throwing the file at the compiler. The Windows build uses an Emacs-private version of sys/stat.h in nt/inc (the one supplied by the Windows runtime does not allow to return meaningful inode numbers), so we will need to add the missing stuff to that header, and bypass lib/sys/stat.h.