From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Strange code in xterm.c
Date: Mon, 20 Dec 2010 05:45:19 -0500
Message-ID: <E1PUdF1-000443-8f@fencepost.gnu.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: lo.gmane.org
X-Trace: dough.gmane.org 1292841936 10507 80.91.229.12 (20 Dec 2010 10:45:36 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Mon, 20 Dec 2010 10:45:36 +0000 (UTC)
To: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 20 11:45:32 2010
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1PUdFE-0005x6-6Q
	for ged-emacs-devel@m.gmane.org; Mon, 20 Dec 2010 11:45:32 +0100
Original-Received: from localhost ([127.0.0.1]:51555 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1PUdFD-0003hl-Lt
	for ged-emacs-devel@m.gmane.org; Mon, 20 Dec 2010 05:45:31 -0500
Original-Received: from [140.186.70.92] (port=48750 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PUdF5-0003hP-Aj
	for emacs-devel@gnu.org; Mon, 20 Dec 2010 05:45:24 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1PUdF4-0002H9-Bk
	for emacs-devel@gnu.org; Mon, 20 Dec 2010 05:45:23 -0500
Original-Received: from fencepost.gnu.org ([140.186.70.10]:55338)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1PUdF4-0002H5-AB
	for emacs-devel@gnu.org; Mon, 20 Dec 2010 05:45:22 -0500
Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.69)
	(envelope-from <eliz@gnu.org>) id 1PUdF1-000443-8f
	for emacs-devel@gnu.org; Mon, 20 Dec 2010 05:45:19 -0500
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:133832
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/133832>

This a large part of the body of x_check_fullscreen:

      int width = FRAME_COLS (f), height = FRAME_LINES (f);
      struct x_display_info *dpyinfo = FRAME_X_DISPLAY_INFO (f);

      switch (f->want_fullscreen)
        {
          /* No difference between these two when there is no WM */
        case FULLSCREEN_BOTH:
        case FULLSCREEN_MAXIMIZED:
          width = x_display_pixel_width (dpyinfo);
          height = x_display_pixel_height (dpyinfo);
          break;
        case FULLSCREEN_WIDTH:
          width = x_display_pixel_width (dpyinfo);
          break;
        case FULLSCREEN_HEIGHT:
          height = x_display_pixel_height (dpyinfo);
        }

      if (FRAME_COLS (f) != width || FRAME_LINES (f) != height)
        {
          change_frame_size (f, height, width, 0, 1, 0);
          SET_FRAME_GARBAGED (f);
          cancel_mouse_face (f);
        }

Am I missing something, or does it mix up display dimensions in pixels
and in character units?