all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Glenn Morris" <rgm@gnu.org>, "Vida Gábor" <vidagabor@gmail.com>
Cc: 7588@debbugs.gnu.org
Subject: bug#7588: smtpmail: wrong file name for queued mail on Windows
Date: Wed, 08 Dec 2010 09:56:13 -0500	[thread overview]
Message-ID: <E1PQLRF-0000x2-09@fencepost.gnu.org> (raw)
In-Reply-To: <qm8w012b3z.fsf@fencepost.gnu.org> (message from Glenn Morris on Tue, 07 Dec 2010 22:32:16 -0500)

> From: Glenn Morris <rgm@gnu.org>
> Date: Tue, 07 Dec 2010 22:32:16 -0500
> Cc: 
> 
> Version: 23.3
> 
> Thanks; fixed.

Thanks, but I don't understand why is such a fix needed.  The code in
question (unless I'm missing something) did this:

	    (let* ((file-data
		    (expand-file-name
		     (format "%s_%i"
			     (format-time-string "%Y-%m-%d_%H:%M:%S")
			     (setq smtpmail-queue-counter
				   (1+ smtpmail-queue-counter)))
		     smtpmail-queue-dir))
		   (file-data (convert-standard-filename file-data))

The call to convert-standard-filename should, on MS-Windows, replace
all characters invalid in a file name with a `!'.  I just tried that
now, on Windows, and it did precisely that.

To the OP: could you please see why this code didn't DTRT for you in
the first place?  According to the bug report, you are using a version
of Emacs post 23.1, and I just verified that 23.1 as released does
have the above fragment.

Thanks.





  reply	other threads:[~2010-12-08 14:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 23:26 bug#7588: smtpmail: wrong file name for queued mail on Windows Vida Gábor
2010-12-08  3:32 ` Glenn Morris
2010-12-08 14:56   ` Eli Zaretskii [this message]
2010-12-08 19:31     ` Glenn Morris
2010-12-08 21:23       ` Eli Zaretskii
2010-12-08 22:10     ` Vida Gábor
2010-12-08 22:39       ` Eli Zaretskii
2010-12-09 19:14         ` Eli Zaretskii
2010-12-09 12:24     ` Jason Rumney
2010-12-09 14:16       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1PQLRF-0000x2-09@fencepost.gnu.org \
    --to=eliz@gnu.org \
    --cc=7588@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    --cc=vidagabor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.