From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check):Convert colors to hexadecimal with shr-color->hexadecimal. Date: Wed, 24 Nov 2010 06:35:23 -0500 Message-ID: References: <961v6bom3j.fsf@fencepost.gnu.org> <87eiabdc04.fsf@stupidchicken.com> <87ipznhhe3.fsf@keller.adm.naquadah.org> <87mxoz7mml.fsf@stupidchicken.com> <874ob71y6v.fsf@stupidchicken.com> <4A76DA00C61D4637AC671E53FB7A4FCB@us.oracle.com> <87d3pvf5s2.fsf@keller.adm.naquadah.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1290600678 24283 80.91.229.12 (24 Nov 2010 12:11:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 24 Nov 2010 12:11:18 +0000 (UTC) Cc: larsi@gnus.org, emacs-devel@gnu.org To: Julien Danjou Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 24 13:11:14 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PLEBu-0002rE-5W for ged-emacs-devel@m.gmane.org; Wed, 24 Nov 2010 13:11:14 +0100 Original-Received: from localhost ([127.0.0.1]:60814 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLEBs-0007zD-UA for ged-emacs-devel@m.gmane.org; Wed, 24 Nov 2010 07:11:13 -0500 Original-Received: from [140.186.70.92] (port=43831 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLDdL-0005XV-9J for emacs-devel@gnu.org; Wed, 24 Nov 2010 06:35:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLDdH-00024L-9J for emacs-devel@gnu.org; Wed, 24 Nov 2010 06:35:31 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:51269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLDdH-00024H-7l for emacs-devel@gnu.org; Wed, 24 Nov 2010 06:35:27 -0500 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1PLDdD-00037m-Jb; Wed, 24 Nov 2010 06:35:23 -0500 In-reply-to: <87d3pvf5s2.fsf@keller.adm.naquadah.org> (message from Julien Danjou on Wed, 24 Nov 2010 10:08:13 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:133114 Archived-At: > From: Julien Danjou > Date: Wed, 24 Nov 2010 10:08:13 +0100 > Cc: 'Lars Magne Ingebrigtsen' , emacs-devel@gnu.org > > Color-lab has been built upon a specific need, which resulted in the CIE > Delta E 2000 formula to be implemented. Some helper functions dealing > with colors have been written, like CIE XYZ and CIE Lab conversion in > the process. > > All of this is not present in hexrgb, and hexrgb is not present in Emacs. > > I admit: color-lab has 50 SLOC for 2 functions (rgb->hsl and rgb->hsv) > which are in hexrgb, but they are even not used at all by the CIE code. > > So I think it's really unfair to stand up and point at this package like > it's something that should not have been done. > > Now if you want to merge hexrgb and color-lab, why not, but stop > pointing at other people work because some is not included in Emacs. > > I can't do anything about it. Perhaps we could all stop being apologetic and pointing fingers at one another, and see one important lesson to be learned here: that before adding a package to Emacs, the contributor should talk to the head maintainers about where the new package should be and whether it should be a new one or an addition to an existing one.